Don't crash when sharing a location with no maptiler apikey (#919)

Marco Romano · web-flow · commit cec87ee6a866 · 2023-07-19T16:33:50.000+02:00
Related to: - element-hq/element-meta#1682
diff --git a/features/location/impl/src/main/kotlin/io/element/android/features/location/impl/send/SendLocationView.kt b/features/location/impl/src/main/kotlin/io/element/android/features/location/impl/send/SendLocationView.kt
@@ -133,7 +133,10 @@ fun SendLocationView(
                         )
                     )
                 },
-                modifier = Modifier.clickable {
+                modifier = Modifier.clickable(
+                    // target is null when the map hasn't loaded (or api key is wrong) so we disable the button
+                    enabled = cameraPositionState.position.target != null
+                ) {
                     state.eventSink(
                         SendLocationEvents.SendLocation(
                             cameraPosition = SendLocationEvents.SendLocation.CameraPosition(

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,10 @@ fun SendLocationView(`
`133`	`133`	`)`
`134`	`134`	`)`
`135`	`135`	`},`
`136`		`- modifier = Modifier.clickable {`
	`136`	`+ modifier = Modifier.clickable(`
	`137`	`+ // target is null when the map hasn't loaded (or api key is wrong) so we disable the button`
	`138`	`+ enabled = cameraPositionState.position.target != null`
	`139`	`+ ) {`
`137`	`140`	`state.eventSink(`
`138`	`141`	`SendLocationEvents.SendLocation(`
`139`	`142`	`cameraPosition = SendLocationEvents.SendLocation.CameraPosition(`