Skip to content

Commit f2c63a5

Browse files
committed
Do not render filename of voice message.
1 parent 461c314 commit f2c63a5

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

libraries/eventformatter/impl/src/main/kotlin/io/element/android/libraries/eventformatter/impl/DefaultPinnedMessagesBannerFormatter.kt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,9 @@ class DefaultPinnedMessagesBannerFormatter @Inject constructor(
9595
messageType.bestDescription.prefixWith(CommonStrings.common_audio)
9696
}
9797
is VoiceMessageType -> {
98-
messageType.bestDescription.prefixWith(CommonStrings.common_voice_message)
98+
// In this case, do not use bestDescription, because the filename is useless, only use the caption if available.
99+
messageType.caption?.prefixWith(sp.getString(CommonStrings.common_voice_message))
100+
?: sp.getString(CommonStrings.common_voice_message)
99101
}
100102
is OtherMessageType -> {
101103
messageType.body

libraries/eventformatter/impl/src/test/kotlin/io/element/android/libraries/eventformatter/impl/DefaultPinnedMessagesBannerFormatterTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,11 @@ class DefaultPinnedMessagesBannerFormatterTest {
159159
val expectedResult = when (type) {
160160
is VideoMessageType,
161161
is AudioMessageType,
162-
is VoiceMessageType,
163162
is ImageMessageType,
164163
is StickerMessageType,
165164
is FileMessageType,
166165
is LocationMessageType -> AnnotatedString::class.java
166+
is VoiceMessageType,
167167
is EmoteMessageType,
168168
is TextMessageType,
169169
is NoticeMessageType,
@@ -176,7 +176,7 @@ class DefaultPinnedMessagesBannerFormatterTest {
176176
val expectedResult = when (type) {
177177
is VideoMessageType -> "Video: Shared body"
178178
is AudioMessageType -> "Audio: Shared body"
179-
is VoiceMessageType -> "Voice message: Shared body"
179+
is VoiceMessageType -> "Voice message"
180180
is ImageMessageType -> "Image: Shared body"
181181
is StickerMessageType -> "Sticker: Shared body"
182182
is FileMessageType -> "File: Shared body"

0 commit comments

Comments
 (0)