Don't display security banner for unknown RecoveryState (#3579)

* Don't display security banner for unknown `RecoveryState`

* Don't display 'set up recovery' if its status is unknown.

Add more screenshot tests.

* Update screenshots

---------

Co-authored-by: ElementBot <[email protected]>

Author: jmartinesp

features/roomlist/impl/src/main/kotlin/io/element/android/features/roomlist/impl/RoomListPresenter.kt

@@ -186,9 +186,9 @@ class RoomListPresenter @Inject constructor(
                     currentSecurityBannerDismissed -> SecurityBannerState.None
                     syncState == SyncState.Running -> {
                         when (recoveryState) {
-                            RecoveryState.UNKNOWN,
                             RecoveryState.DISABLED -> SecurityBannerState.SetUpRecovery
                             RecoveryState.INCOMPLETE -> SecurityBannerState.RecoveryKeyConfirmation
+                            RecoveryState.UNKNOWN,
                             RecoveryState.WAITING_FOR_SYNC,
                             RecoveryState.ENABLED -> SecurityBannerState.None
                         }

features/roomlist/impl/src/test/kotlin/io/element/android/features/roomlist/impl/RoomListPresenterTest.kt

@@ -236,7 +236,9 @@ class RoomListPresenterTest {
 
     @Test
     fun `present - handle DismissRecoveryKeyPrompt`() = runTest {
-        val encryptionService = FakeEncryptionService()
+        val encryptionService = FakeEncryptionService().apply {
+            recoveryStateStateFlow.emit(RecoveryState.DISABLED)
+        }
         val roomListService = FakeRoomListService().apply {
             postAllRoomsLoadingState(RoomList.LoadingState.Loaded(1))
         }

features/securebackup/impl/src/main/kotlin/io/element/android/features/securebackup/impl/root/SecureBackupRootStateProvider.kt

@@ -20,6 +20,11 @@ open class SecureBackupRootStateProvider : PreviewParameterProvider<SecureBackup
             aSecureBackupRootState(backupState = BackupState.UNKNOWN, doesBackupExistOnServer = AsyncData.Success(true)),
             aSecureBackupRootState(backupState = BackupState.UNKNOWN, doesBackupExistOnServer = AsyncData.Success(false)),
             aSecureBackupRootState(backupState = BackupState.UNKNOWN, doesBackupExistOnServer = AsyncData.Failure(Exception("An error"))),
+            aSecureBackupRootState(backupState = BackupState.WAITING_FOR_SYNC),
+            aSecureBackupRootState(backupState = BackupState.CREATING),
+            aSecureBackupRootState(backupState = BackupState.RESUMING),
+            aSecureBackupRootState(backupState = BackupState.DOWNLOADING),
+            aSecureBackupRootState(backupState = BackupState.DISABLING),
             aSecureBackupRootState(backupState = BackupState.ENABLED),
             aSecureBackupRootState(recoveryState = RecoveryState.UNKNOWN),
             aSecureBackupRootState(recoveryState = RecoveryState.ENABLED),

features/securebackup/impl/src/main/kotlin/io/element/android/features/securebackup/impl/root/SecureBackupRootView.kt

@@ -143,8 +143,8 @@ fun SecureBackupRootView(
 
         // Setup recovery
         when (state.recoveryState) {
-            RecoveryState.WAITING_FOR_SYNC -> Unit
             RecoveryState.UNKNOWN,
+            RecoveryState.WAITING_FOR_SYNC -> Unit
             RecoveryState.DISABLED -> {
                 PreferenceText(
                     title = stringResource(id = R.string.screen_chat_backup_recovery_action_setup),