following room upgrades loses notification setting

[HarHarLinks]

Steps to reproduce

1. Join a room such as !vlnjqGLpLJlFmBSkfQ:matrix.org
2. Customize notifications top this room, e.g. to pings only
3. Wait for the room to get upgraded
4. Click jump to new room !KDiNABdMiGixPIk0YCQ7syudVPr8hqpxpJl_qEUlxWQ
5. Join it
6. Check room notification settings

Outcome

What did you expect?

The "same" room will have the same notification settings

What happened instead?

Default notifications on the new room

Your phone model

No response

Operating system version

No response

Application version and app store

25.11.3

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

[bmarty]

Thanks for reporting. I have also noticed that the banned users are not banned again in the new room. I guess this is how room upgrade works...
@mxandreas do you think it worth spending time on this issue? I do not think so personnaly even if I agree that upgrading a room should have the less impact as possible on the user experience / user custom configuration.

[HarHarLinks]

The same applies to Element Web btw.

[mxandreas]

do you think it worth spending time on this issue? I do not think so personnaly even if I agree that upgrading a room should have the less impact as possible on the user experience / user custom configuration

Yes, in an ideal world, various room "settings" or "configurations" would not be lost during the upgrade. However, this is not only an EX issue (AFAIK), as well as implementation-wise it would something that probably the server would be better to handle, in particular as no one will ever trigger upgrade from a mobile client.

The topic would require a more comprehensive approach (e.g. what data needs to be copied over), it is not something we can fix on the go on mobile side only.

[HarHarLinks]

Note this issue occurred where the room was not upgraded using the upgrade API and also I'm on the same homeserver as the new room owner.

Thanks for reporting. I have also noticed that the banned users are not banned again in the new room.

I think this is related but a different problem and actually considered best practice in T&S circles.

[sandhose]

This is actually a server problem when the upgrade is done 'manually', which is what the Trust and Safety team is currently doing, read: element-hq/synapse#19199