Skip to content

Feature : Join Space (WIP) #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 24, 2025
Merged

Feature : Join Space (WIP) #5378

merged 13 commits into from
Sep 24, 2025

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 19, 2025 •
edited
Loading

Content

First Iteration for joining a Space.
The PR also takes care of updating the design, which affects Join Room.
There are still some bits to handle to manage all cases (needs some new strings specifics to Spaces).

Motivation and context

Partially #5297

Screenshots / GIFs

See recorded screenshots

Tests

  • Makes sure you have some top level Spaces
  • Navigate to an inner space through a top level Space
  • You should be able to join the space.
  • You can also use another account and send an invite to an inner space.
  • You can also create a permalink to a space and access it.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2025 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5memVf

@bmarty bmarty added the PR-Wip For anything that isn't ready to ship and will be enabled at a later date label Sep 22, 2025
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 22, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 22, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 22, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.79310% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.37%. Comparing base (d391be7) to head (f3a9646).
⚠️ Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...ndroid/features/joinroom/impl/JoinRoomPresenter.kt 78.46% 7 Missing and 7 partials ⚠️
...ent/android/features/joinroom/impl/JoinRoomView.kt 93.67% 1 Missing and 4 partials ⚠️
.../element/android/features/invite/api/InviteData.kt 0.00% 4 Missing ⚠️
...id/features/joinroom/impl/JoinRoomStateProvider.kt 88.23% 2 Missing ⚠️
...nsystem/atomic/atoms/RoomPreviewDescriptionAtom.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5378      +/-   ##
===========================================
- Coverage    80.37%   80.37%   -0.01%     
===========================================
  Files         2282     2282              
  Lines        63071    63151      +80     
  Branches      7887     7893       +6     
===========================================
+ Hits         50694    50758      +64     
- Misses        9464     9478      +14     
- Partials      2913     2915       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 24, 2025
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Sep 24, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ganfra ganfra marked this pull request as ready for review September 24, 2025 10:18
@ganfra ganfra requested a review from a team as a code owner September 24, 2025 10:18
@ganfra ganfra requested review from bmarty and removed request for a team September 24, 2025 10:18
bmarty
bmarty approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@bmarty bmarty merged commit 6cd0af9 into develop Sep 24, 2025
36 of 37 checks passed
@bmarty bmarty deleted the feature/fga/join_space branch September 24, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
PR-Wip For anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganfra @bmarty @ElementBot