Skip to content

Feature: Add minimized video service (YouTube-style PiP) #5423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: feature/bma/minimizeVideoPlayer
Choose a base branch
from
Open

Feature: Add minimized video service (YouTube-style PiP) #5423

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9f024c7
feat(floating-video): add system-wide mini-player draft
aliIsazadeh Sep 26, 2025
a111b5e
Merge branch 'element-hq:develop' into minimized-video
aliIsazadeh Sep 27, 2025
16db3ab
fixed the bug of video being full size at first
aliIsazadeh Sep 27, 2025
bbc5458
Merge remote-tracking branch 'origin/minimized-video' into minimized-…
aliIsazadeh Sep 27, 2025
0f3fec9
Merge branch 'develop' into minimized-video
aliIsazadeh Sep 30, 2025
fe18ef7
-remove unused setMinimize
aliIsazadeh Sep 30, 2025
49a765d
-removed added icons and string and using existing icons and strings
aliIsazadeh Sep 30, 2025
daf7461
-adjusting maximize button size
aliIsazadeh Sep 30, 2025
46d226b
Merge branch 'element-hq:develop' into minimized-video
aliIsazadeh Sep 30, 2025
d07dc1e
-remove extra service declaration of service in app manifest
aliIsazadeh Sep 30, 2025
b99e67f
Merge remote-tracking branch 'origin/minimized-video' into minimized-…
aliIsazadeh Sep 30, 2025
2f9f56d
-remove extra import
aliIsazadeh Sep 30, 2025
7c13c1f
-remove extra string file
aliIsazadeh Oct 2, 2025
b9f415f
refactor: Convert floating video overlay to Compose with direct view …
aliIsazadeh Oct 4, 2025
a90c19a
Merge branch 'develop' into minimized-video
aliIsazadeh Oct 6, 2025
6a3cb61
-revert changes in gradle.properties and project
aliIsazadeh Oct 11, 2025
f91d167
- Broke down large FloatingVideoService into multiple smaller files f…
aliIsazadeh Oct 12, 2025
1466e74
Merge remote-tracking branch 'origin/minimized-video' into minimized-…
aliIsazadeh Oct 12, 2025
b33720c
fix(video): stabilize floating video behavior
aliIsazadeh Oct 13, 2025
d4228a8
-Converted VideoDataRepository to @SingleIn(AppScope::class) with @In…
aliIsazadeh Oct 16, 2025
19defb1
-on video completes the minimized video gose away
aliIsazadeh Oct 17, 2025
2cf92d5
-Toast for display over apps persmission(string needs to be added to …
aliIsazadeh Oct 17, 2025
44105d2
Merge branch 'element-hq:develop' into minimized-video
aliIsazadeh Oct 17, 2025
1978751
Merge branch 'develop' into minimized-video
aliIsazadeh Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<!-- To be able to install APK from the application -->
<uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" />

<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" />
Copy link
Member

@bmarty bmarty Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This declaration should be located in the AndroidManifest of the module where FloatingVideoService is defined.

Copy link
Author

@aliIsazadeh aliIsazadeh Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<application
android:name=".ElementXApplication"
android:allowBackup="false"
Expand All @@ -26,7 +26,10 @@
android:supportsRtl="true"
android:theme="@style/Theme.ElementX"
tools:targetApi="33">

<service
Copy link
Member

@bmarty bmarty Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This declaration should be located in the AndroidManifest of the module where FloatingVideoService is defined.

Copy link
Author

@aliIsazadeh aliIsazadeh Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh of course

Copy link
Author

@aliIsazadeh aliIsazadeh Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@bmarty bmarty Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and remove the declaration from here?

Copy link
Author

@aliIsazadeh aliIsazadeh Sep 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh shoot sorry i forgot about that
yeah now i removed it

android:name="io.element.android.libraries.mediaviewer.impl.floatingvideo.FloatingVideoService"
android:enabled="true"
android:exported="false" />
<meta-data
android:name="com.google.android.gms.car.application"
android:resource="@xml/automotive_app_desc" />
Expand Down
Loading