-
Notifications
You must be signed in to change notification settings - Fork 339
Display non-technical error on media gallery #5487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jmartinesp
wants to merge
5
commits into
develop
Choose a base branch
from
fix/display-non-technical-error-on-gallery-allow-retry
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b1b4bf3
Modify `AsyncFailure` so it takes `String?` instead of a `Throwable?`
jmartinesp f0b9766
Adapt the error components in `MediaViewerView` and `MediaGalleryView…
jmartinesp e891d96
Adapt other components using `AsyncFailure` too
jmartinesp 87fc1b1
Allow retry action in both the gallery and media viewer when the medi…
jmartinesp 6ed35b0
Update screenshots
ElementBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 2 additions & 2 deletions
4
...pshots/images/libraries.mediaviewer.impl.gallery_MediaGalleryView_Day_10_en.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...apshots/images/libraries.mediaviewer.impl.gallery_MediaGalleryView_Day_9_en.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...hots/images/libraries.mediaviewer.impl.gallery_MediaGalleryView_Night_10_en.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...shots/images/libraries.mediaviewer.impl.gallery_MediaGalleryView_Night_9_en.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions
4
...st/snapshots/images/libraries.mediaviewer.impl.viewer_MediaViewerView_15_en.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this
Failed to load mediamessage comes from a fakeException(message = "Failed to load media"). This is not localized and in a real example can expose internal state of the app.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should ever use the message exception anyway :/
We probably need some clean up on the error ui through the entire app, which might require some design/product.