Skip to content

Try fixing forced dark mode issues on MIUI on Android 10 #5708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Try fixing forced dark mode issues on MIUI on Android 10 #5708

wants to merge 2 commits into from
+4 −2

Conversation

@jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Nov 10, 2025 •
edited
Loading

Content

Makes sure users in Android 10 can't force the dark theme in the app, since it can display a broken color scheme.

Motivation and context

Tried to fix #5703. It does make the problem better, but it doesn't really fix it as it wasn't the root cause of the problem.

Tests

I don't know how you can test this without an Android 10 device using MIUI 😅 .

Tested devices

  • Physical
  • Emulator
  • OS version(s): 10 (by an external user).

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bLLphZ

@jmartinesp jmartinesp mentioned this pull request Nov 10, 2025
Open
@codecov
Copy link

codecov bot commented Nov 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.62%. Comparing base (2120b5c) to head (ad40d73).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #5708   +/-   ##
========================================
  Coverage    79.62%   79.62%           
========================================
  Files         2432     2432           
  Lines        65339    65339           
  Branches      8327     8327           
========================================
  Hits         52024    52024           
  Misses       10336    10336           
  Partials      2979     2979

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp force-pushed the fix/disable-force-dark-mode-on-android-10 branch from c28e70f to 6a5e74c Compare November 10, 2025 13:03
@jmartinesp jmartinesp force-pushed the fix/disable-force-dark-mode-on-android-10 branch from 6a5e74c to 69781ad Compare November 13, 2025 11:03
@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Nov 14, 2025
@jmartinesp jmartinesp marked this pull request as ready for review November 14, 2025 13:42
@jmartinesp jmartinesp requested a review from a team as a code owner November 14, 2025 13:42
@jmartinesp jmartinesp requested review from ganfra and removed request for a team November 14, 2025 13:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ganfra ganfra Awaiting requested review from ganfra ganfra is a code owner automatically assigned from element-hq/element-x-android-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

PR-Bugfix For bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Button text is unreadable with Dark theme

2 participants

@jmartinesp