"$foo mentioned you" notifications generally lie.

[ara4n]

Steps to reproduce

1. You receive a notification saying "$foo mentioned you: $msg"
2. You wince because typically $foo didn't mention you. instead they either:

• replied to a message you sent
• used @room
• or otherwise didn't actually intentionally mention you.

Outcome

What did you expect?

imo, notifications shouldn't waste space with "$foo mentioned you" at all. If we really want do to this, they certainly shouldn't include "$foo mentioned you" unless $foo really did intentionally mention you.

What happened instead?

All sorts of things seem to trigger this. I can't actually remember seeing this notification when someone actually intentionally mentioned me, in fact.

Your phone model

No response

Operating system version

No response

Application version

508

Homeserver

No response

Will you send logs?

No

[Velin92]

So the hasMention check coming from the SDK notification obeys to some push rules that recognise as a mention also non intentional ones (if they are not supported from the sender), replies and room mentions. Probably we want at least for the reply case to distinguish between them.
However maybe is worth also discussing from a design or product point of view if we want to keep the additional copy or change it, or what should be intended behaviour for replies or for all room mentions.
@VolkerJunginger

[jmartinesp]

I see we never made a decision. Should we remove the different text or try to detect intentional mentions only?

[manuroe]

What will happen if we remove false positives for intentional mentions and fix the computation of hasMention in the SDK?

[jmartinesp]

Then it should be working as expected: replies won't say you've been mentioned, and neither will messages with @room. Non-intentional mentions however, won't say you've been mentioned, but I think that's expected.

[manuroe]

yes, this is right.

[jmartinesp]

So we discussed this with several devs in the Rust SDK Development room and it seems like there's no good way to distinguish between mentions and replies given the current state of the spec:

1. We have intentional mentions, but the spec says for backwards compatibility clients should add the sender of the replied to message as an intentional mention when replying. There's no way to distinguish between a reply to you that mentions another user and a reply to other user that mentions you given the current data.
2. There is this MSC, and either the proposed implementation or the alternative one would help us with this problem.
3. If we don't follow the spec's suggestion (as it's just a suggestion) other clients may have unexpected behaviour and we'd still display 'mentioned you' for messages of users who replied to some message of yours in one of those clients.
4. We could technically try to check the message contents for actual mentions, but that's a 🐰 hole I'd rather not jump into as it has many possible edge cases.