Skip to content

Commit 6a2d341

Browse files
sandhoseCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
1 parent ef50efe commit 6a2d341

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

crates/cli/src/commands/doctor.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,10 @@ Error details: {e}
290290
match result {
291291
Ok(response) => {
292292
let status = response.status();
293-
// We're missing the localpart parameter, so expect a 400
293+
// We intentionally omit the required 'localpart' parameter in this request.
294+
// If authentication is successful, Synapse returns a 400 Bad Request because of the missing parameter.
295+
// If authentication fails, Synapse will return a 403 Forbidden.
296+
// If the MAS integration isn't enabled, Synapse will return a 404 Not found.
294297
if status == StatusCode::BAD_REQUEST {
295298
info!(
296299
r#"✅ The Synapse admin API is reachable with authentication at "{mas_api}"."#

docs/setup/homeserver.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,4 @@ To do so, you need to:
6666
- `enabled: true`
6767
- `endpoint` set to the URL of the authentication service
6868
- `secret` set to the same secret as the `admin_token` that was set in the `msc3861` section
69-
- Optionally, remove the client provisionned for Synapse in the `clients` section of the MAS configuration
69+
- Optionally, remove the client provisioned for Synapse in the `clients` section of the MAS configuration

0 commit comments

Comments
 (0)