Prevent double-fetch of translations

Author: sandhose

frontend/src/@types/i18next.d.ts

@@ -5,15 +5,15 @@
 // Please see LICENSE in the repository root for full details.
 
 import "i18next";
-import type frontend from "../../locales/en.json";
+import type translation from "../../locales/en.json";
 
 declare module "i18next" {
   interface CustomTypeOptions {
     keySeparator: ".";
     pluralSeparator: ":";
-    defaultNS: "frontend";
+    defaultNS: "translation";
     resources: {
-      frontend: typeof frontend;
+      translation: typeof translation;
     };
   }
 }

frontend/src/i18n.ts

@@ -89,7 +89,7 @@ i18n
     fallbackLng: "en",
     keySeparator: ".",
     pluralSeparator: ":",
-    defaultNS: "frontend",
+    defaultNS: "translation",
     supportedLngs,
     interpolation: {
       escapeValue: false, // React has built-in XSS protections

frontend/src/i18n/password_changes.ts

@@ -21,7 +21,7 @@ import { SetPasswordStatus } from "../gql/graphql";
  * Throws an error if the status is not known.
  */
 export function translateSetPasswordError(
-  t: TFunction<"frontend", undefined>,
+  t: TFunction,
   status: SetPasswordStatus | undefined,
 ): string | undefined {
   switch (status) {

frontend/src/utils/password_complexity/index.ts

@@ -70,7 +70,7 @@ export interface PasswordComplexity {
 /** Estimates the complexity of a password. */
 export async function estimatePasswordComplexity(
   password: string,
-  t: TFunction<"frontend", undefined>,
+  t: TFunction,
 ): Promise<PasswordComplexity> {
   const scorerResult = await zxcvbnAsync(password);
 
@@ -96,10 +96,7 @@ export async function estimatePasswordComplexity(
 }
 
 /** Returns a translated string corresponding to the 0 to 4 score. */
-function translateScore(
-  score: 0 | 1 | 2 | 3 | 4,
-  t: TFunction<"frontend", undefined>,
-): string {
+function translateScore(score: 0 | 1 | 2 | 3 | 4, t: TFunction): string {
   switch (score) {
     case 0:
       return t("frontend.password_strength.score.0");
@@ -117,7 +114,7 @@ function translateScore(
 /** Returns a translated string corresponding to a password improvement suggestion from zxcvbn-ts. */
 function translateSuggestion(
   suggestionCode: string,
-  t: TFunction<"frontend", undefined>,
+  t: TFunction,
 ): string | undefined {
   switch (suggestionCode) {
     case "allUppercase":
@@ -154,7 +151,7 @@ function translateSuggestion(
 /** Returns a translated string corresponding to a weak password warning from zxcvbn-ts. */
 function translateWarning(
   warningCode: string,
-  t: TFunction<"frontend", undefined>,
+  t: TFunction,
 ): string | undefined {
   switch (warningCode) {
     case "commonNames":