templates: fix reliance on lax undefined behaviour

reivilibre · reivilibre · commit adad55161bed · 2025-10-24T14:27:35.000+01:00
diff --git a/templates/base.html b/templates/base.html
@@ -28,7 +28,7 @@
     {{ captcha.head() }}
   </head>
   <body>
-    <div class="layout-container{% if consent_page %} consent{% endif %}">
+    <div class="layout-container{% if consent_page is defined %} consent{% endif %}">
       {% block content %}{% endblock content %}
       {% include "components/footer.html" %}
     </div>
diff --git a/templates/components/footer.html b/templates/components/footer.html
@@ -7,27 +7,27 @@
 -#}
 
 <footer class="legal-footer">
-  {%- if branding.policy_uri or branding.tos_uri -%}
+  {%- if branding.policy_uri is defined or branding.tos_uri is defined -%}
     <nav>
-      {%- if branding.policy_uri -%}
+      {%- if branding.policy_uri is defined -%}
         <a href="{{ branding.policy_uri }}" referrerpolicy="no-referrer" title="{{ _('branding.privacy_policy.alt') }}" class="cpd-link" data-kind="primary">
           {{- _("branding.privacy_policy.link") -}}
         </a>
       {%- endif -%}
 
-      {%- if branding.policy_uri and branding.tos_uri -%}
+      {%- if branding.policy_uri is defined and branding.tos_uri is defined -%}
         <div class="separator" aria-hidden="true">•</div>
       {%- endif -%}
 
-      {%- if branding.tos_uri -%}
+      {%- if branding.tos_uri is defined -%}
         <a href="{{ branding.tos_uri }}" referrerpolicy="no-referrer" title="{{ _('branding.terms_and_conditions.alt') }}" class="cpd-link" data-kind="primary">
           {{- _("branding.terms_and_conditions.link") -}}
         </a>
       {%- endif -%}
     </nav>
   {%- endif -%}
 
-  {%- if branding.imprint -%}
+  {%- if branding.imprint is defined -%}
     <p class="imprint">{{ branding.imprint }}</p>
   {%- endif -%}
 </footer>
diff --git a/templates/pages/register/password.html b/templates/pages/register/password.html
@@ -49,7 +49,7 @@ <h1 class="title">{{ _("mas.register.create_account.heading") }}</h1>
       <input {{ field.attributes(f) }} class="cpd-text-control" type="password" autocomplete="new-password" required />
     {% endcall %}
 
-    {% if branding.tos_uri %}
+    {% if branding.tos_uri is defined %}
       {% call(f) field.field(label=_("mas.register.terms_of_service", tos_uri=branding.tos_uri), name="accept_terms", form_state=form, inline=true, class="my-4") %}
         <div class="cpd-form-inline-field-control">
           <div class="cpd-checkbox-container">
diff --git a/templates/pages/upstream_oauth2/do_register.html b/templates/pages/upstream_oauth2/do_register.html
@@ -175,7 +175,7 @@ <h3 class="provider">
       </div>
     {% endif %}
 
-    {% if branding.tos_uri %}
+    {% if branding.tos_uri is defined %}
       {% call(f) field.field(label=_("mas.register.terms_of_service", tos_uri=branding.tos_uri), name="accept_terms", form_state=form_state, inline=true, class="my-4") %}
         <div class="cpd-form-inline-field-control">
           <div class="cpd-checkbox-container">
