Check that sample rates are in range in the config

Author: sandhose

crates/cli/src/main.rs

@@ -109,10 +109,8 @@ async fn try_main() -> anyhow::Result<ExitCode> {
     // Load the base configuration files
     let figment = opts.figment();
 
-    // Telemetry config could fail to load, but that's probably OK, since the whole
-    // config will be loaded afterwards, and crash if there is a problem.
-    // Falling back to default.
-    let telemetry_config = TelemetryConfig::extract(&figment).unwrap_or_default();
+    let telemetry_config =
+        TelemetryConfig::extract(&figment).context("Failed to load telemetry config")?;
 
     // Setup Sentry
     let sentry = sentry::init((

crates/config/src/sections/telemetry.rs

@@ -193,4 +193,35 @@ impl TelemetryConfig {
 
 impl ConfigurationSection for TelemetryConfig {
     const PATH: Option<&'static str> = Some("telemetry");
+
+    fn validate(&self, _figment: &figment::Figment) -> Result<(), figment::Error> {
+        if let Some(sample_rate) = self.sentry.sample_rate {
+            if !(0.0..=1.0).contains(&sample_rate) {
+                return Err(figment::error::Error::custom(
+                    "Sentry sample rate must be between 0.0 and 1.0",
+                )
+                .with_path("sentry.sample_rate"));
+            }
+        }
+
+        if let Some(sample_rate) = self.sentry.traces_sample_rate {
+            if !(0.0..=1.0).contains(&sample_rate) {
+                return Err(figment::error::Error::custom(
+                    "Sentry sample rate must be between 0.0 and 1.0",
+                )
+                .with_path("sentry.traces_sample_rate"));
+            }
+        }
+
+        if let Some(sample_rate) = self.tracing.sample_rate {
+            if !(0.0..=1.0).contains(&sample_rate) {
+                return Err(figment::error::Error::custom(
+                    "Tracing sample rate must be between 0.0 and 1.0",
+                )
+                .with_path("tracing.sample_rate"));
+            }
+        }
+
+        Ok(())
+    }
 }