Fix reporting of version in prebuilt binaries & docker image #3881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
1016357
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2e393cbc.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-fix-version-reporti.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
Jan 27, 2025
sandhose
added
A-Container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the reporting of the version in pre-built binaries and in the docker image.
This uses a feature from
vergenwhich allows us to override any variables with environment variables.It also tweaks the Docker bake file to introduce a
VERGEN_GIT_DESCRIBEvariable, which is passed down as build arg to the Dockerfile, which is then passed down as environment variable.This way, we can also override the version in the docker image by setting the
VERGEN_GIT_DESCRIBEenvironment variable.Another pass-by change is to set
SOURCE_DATE_EPOCHto the timestamp of the last commit, so that Docker considers the build as being reproducible. Not sure if we get a 1:1 binary match from two independant builds, but it's a good thing to have.