Fix the account page crash introduced in #3893 #3920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
92d1fec
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e819246.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-fix-missing-query-p.matrix-authentication-service-docs.pages.dev |
reivilibre
approved these changes
Jan 30, 2025
|
maybe |
That changed in axum 0.8: the extractor has to implement OptionalFromRequestParts for that. This is because Option would void most errors that you'd actually want to handle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
Query<Option<T>>is not really a valid extractor, which made Axum show a 500 error on the account page