Add admin APIs to finish individual sessions #5091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
7e3df55
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://09cdcbe5.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-admin-api-sessions.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/admin-api/sessions-finish
branch
from
1f72136 to
b856c88
Compare
reivilibre
approved these changes
Oct 7, 2025
| repo.save().await?; | ||
|
|
||
| Ok(Json(SingleResponse::new( | ||
| CompatSession::from((session, sso_login)), |
There was a problem hiding this comment.
slight eyebrow raise at CompatSession::from((CompatSession, Option<CompatSsoLogin>)) but I guess it's OK and matches what we do in other places
| // If the session has a user associated with it, schedule a job to sync devices | ||
| if let Some(user_id) = session.user_id { | ||
| tracing::info!(user.id = %user_id, "Scheduling device sync job for user"); | ||
| let job = SyncDevicesJob::new_for_id(user_id); |
There was a problem hiding this comment.
weirdly inconsistent with how it's done for CompatSessions; why use the db-loaded User in one place and the ID in the other?
I think just using the user_id should win, though; should be no need to verify the user exists in the DB given the FK constraint should do that for us
There was a problem hiding this comment.
Good q, dunno why I did that on the compat sessions. Fixed that in 7e3df55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 3 endpoints to finish sessions, one for each kind of session.