Skip to content

Highlight dangerous scopes when consenting to them #5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2025
Merged

Highlight dangerous scopes when consenting to them #5180

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
806a815
Highlight dangerous scopes when consenting to them
sandhose Oct 22, 2025
c9fd465
Make the font slightly bolder on dangerous scopes
sandhose Oct 22, 2025
bc3d3d4
Align the icons used in the session details page
sandhose Oct 22, 2025
820b1d7
Update extracted translations
sandhose Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/SessionDetail/SessionInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const ScopeSendMessages: React.FC = () => {
const ScopeSynapseAdmin: React.FC = () => {
const { t } = useTranslation();
return (
<VisualListItem Icon={IconErrorSolid}>
<VisualListItem Icon={IconErrorSolid} destructive>
{t("mas.scope.synapse_admin")}
</VisualListItem>
);
Expand All @@ -77,7 +77,7 @@ const ScopeSynapseAdmin: React.FC = () => {
const ScopeMasAdmin: React.FC = () => {
const { t } = useTranslation();
return (
<VisualListItem Icon={IconErrorSolid}>
<VisualListItem Icon={IconErrorSolid} destructive>
{t("mas.scope.mas_admin")}
</VisualListItem>
);
Expand Down
11 changes: 11 additions & 0 deletions frontend/src/templates.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,17 @@
width: var(--cpd-space-6x);
color: var(--cpd-color-icon-quaternary);
}

&.dangerous {
border: 1px solid var(--cpd-color-border-critical-subtle);
background-color: var(--cpd-color-bg-critical-subtle);
font: var(--cpd-font-body-md-medium);
color: var(--cpd-color-text-critical-primary);

& > svg {
color: var(--cpd-color-icon-critical-primary);
}
}
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions templates/components/scope.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<li>{{ icon.chat() }}<p>{{ _("mas.scope.view_messages") }}</p></li>
<li>{{ icon.send() }}<p>{{ _("mas.scope.send_messages") }}</p></li>
{% elif scope == "urn:synapse:admin:*" %}
<li>{{ icon.error_solid() }}<p>{{ _("mas.scope.synapse_admin") }}</p></li>
<li class="dangerous">{{ icon.room() }}<p>{{ _("mas.scope.synapse_admin") }}</p></li>
{% elif scope == "urn:mas:admin" %}
<li>{{ icon.error_solid() }}<p>{{ _("mas.scope.mas_admin") }}</p></li>
<li class="dangerous">{{ icon.admin() }}<p>{{ _("mas.scope.mas_admin") }}</p></li>
{% elif scope is startingwith("urn:matrix:client:device:") or scope is startingwith("urn:matrix:org.matrix.msc2967.client:device:") %}
{# We hide this scope #}
{% else %}
Expand Down
Loading