Include the destination in the error of 'Destination mismatch' (#17830)

erikjohnston · web-flow · commit 6c51f8649d5b · 2024-10-29T10:09:25.000Z
To help debug problems such as #17822
diff --git a/changelog.d/17830.misc b/changelog.d/17830.misc
@@ -0,0 +1 @@
+Include the destination in the error of 'Destination mismatch' on federation requests.
diff --git a/synapse/federation/transport/server/_base.py b/synapse/federation/transport/server/_base.py
@@ -113,7 +113,7 @@ async def authenticate_request(
                 ):
                     raise AuthenticationError(
                         HTTPStatus.UNAUTHORIZED,
-                        "Destination mismatch in auth header",
+                        f"Destination mismatch in auth header, received: {destination!r}",
                         Codes.UNAUTHORIZED,
                     )
         if (

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Include the destination in the error of 'Destination mismatch' on federation requests.`
Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ async def authenticate_request(`
`113`	`113`	`):`
`114`	`114`	`raise AuthenticationError(`
`115`	`115`	`HTTPStatus.UNAUTHORIZED,`
`116`		`- "Destination mismatch in auth header",`
	`116`	`+ f"Destination mismatch in auth header, received: {destination!r}",`
`117`	`117`	`Codes.UNAUTHORIZED,`
`118`	`118`	`)`
`119`	`119`	`if (`