Skip to content

Commit b274d65

Browse files
authored
Document that some config options for the user directory are in violation of the Matrix spec (#18548)
Fix #17534 Signed-off-by: Johannes Marbach <[email protected]>
1 parent 49cb783 commit b274d65

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

changelog.d/18548.doc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Document that some config options for the user directory are in violation of the Matrix spec.

docs/usage/configuration/config_documentation.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3808,7 +3808,11 @@ encryption_enabled_by_default_for_room_type: invite
38083808

38093809
This setting has the following sub-options:
38103810

3811-
* `enabled` (boolean): Defines whether users can search the user directory. If false then empty responses are returned to all queries. Defaults to `true`.
3811+
* `enabled` (boolean): Defines whether users can search the user directory. If `false` then empty responses are returned to all queries.
3812+
3813+
*Warning: While the homeserver may determine which subset of users are searched, the Matrix specification requires homeservers to include (at minimum) users visible in public rooms and users sharing a room with the requester. Using `false` improves performance but violates this requirement.*
3814+
3815+
Defaults to `true`.
38123816

38133817
* `search_all_users` (boolean): Defines whether to search all users visible to your homeserver at the time the search is performed. If set to true, will return all users known to the homeserver matching the search query. If false, search results will only contain users visible in public rooms and users sharing a room with the requester.
38143818

schema/synapse-config.schema.yaml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4719,8 +4719,15 @@ properties:
47194719
enabled:
47204720
type: boolean
47214721
description: >-
4722-
Defines whether users can search the user directory. If false then
4722+
Defines whether users can search the user directory. If `false` then
47234723
empty responses are returned to all queries.
4724+
4725+
4726+
*Warning: While the homeserver may determine which subset of users are
4727+
searched, the Matrix specification requires homeservers to include (at
4728+
minimum) users visible in public rooms and users sharing a room with
4729+
the requester. Using `false` improves performance but violates this
4730+
requirement.*
47244731
default: true
47254732
search_all_users:
47264733
type: boolean

0 commit comments

Comments
 (0)