Synapse media repository returns spec incompliant errors

[t3chguy]

Description

synapse/synapse/media/media_repository.py

Lines 366 to 368 in d4af297

	raise SynapseError(
	400, "Media upload limit exceeded", Codes.RESOURCE_LIMIT_EXCEEDED
	)

is not compliant with the spec

The spec states

The error MUST have an admin_contact field to provide the user receiving the error a place to reach out to.

https://spec.matrix.org/v1.15/client-server-api/#other-error-codes

Steps to reproduce

• Breach an upload limit

Homeserver

Any

Synapse Version

Latest

Installation Method

Docker (matrixdotorg/synapse)

Database

Any

Workers

Single process

Platform

Any

Configuration

Default

Relevant log output

None

Anything else that would be useful to know?

No response

[erikjohnston]

So annoyingly actually looks like M_RESOURCE_LIMIT_EXCEEDED is not really the right error code, as its for when the homeserver as a whole goes above their resource limit, rather than individual users. Users themselves are split into M_TOO_LARGE and M_LIMIT_EXCEEDED (which is for "Too Many Requests"), neither of which are really appropriate

[t3chguy]

https://spec.matrix.org/v1.15/client-server-api/#post_matrixmediav3upload says it should be a 403, currently using a 400

The user has reached a quota for uploaded content

[hughns]

I drafted a new error code in matrix-org/matrix-spec-proposals#4335 which I would welcome feedback on.