Implement pagination for MSC2666 #19279
Conversation
| HTTPStatus.BAD_REQUEST, | ||
| "You cannot request a list of shared rooms with yourself", | ||
| errcode=Codes.INVALID_PARAM, | ||
| errcode=Codes.UNKNOWN, |
There was a problem hiding this comment.
This change was made a couple years back on the MSC because 422 is a weird http status that nobody uses
anoadragon453
left a comment
anoadragon453
left a comment
There was a problem hiding this comment.
A few things here and there, but on the whole this is mostly good out of the gate. Thank you for moving this highly-requested feature along @tulir!
There was a problem hiding this comment.
If you're feeling up to it, I would love to see some Complement tests for this endpoint as well.
But not a blocker for this PR (or the spec).
| u1_token = self.login(u1, "pass") | ||
| u2 = self.register_user("user2", "pass") | ||
| u2_token = self.login(u2, "pass") | ||
| self.get_success(self.hs.get_datastores().main.set_ratelimit_for_user(u1, 0, 0)) |
There was a problem hiding this comment.
We should be eliminating the ratelimit in the test homeserver config already:
Lines 186 to 203 in a096fba
Did you find this was necessary? (Or is it just due to us missing rc_room_creation in that config?)
There was a problem hiding this comment.
The test exploded with a 429 in room creation until I added that, I guess it's the missing rc_room_creation
There was a problem hiding this comment.
I had to add both rc_room_creation and rc_invites->per_issuer to make it pass without the ratelimit override
Co-authored-by: Andrew Morgan <[email protected]>
2 participants
Pull Request Checklist