Skip to content

Some pool names are not supported #163

@Phsacar

Description

@Phsacar

Describe the bug

Some pool names cant be interpreted when parsing the benji.yaml

To Reproduce

Create a ceph pool that has underscores in its pool name. And configure it in the ios section.
Try to do a backup :)

Expected behavior

All pool names that are allowed in ceph should work in benji - although that could be hard to implement currently.

Platform and versions (please complete the following information):

Latest Helm chart ( as of 04 2024 )
Doesn't matter

Additional context

Hi,
additional info:
Bug is in "/src/benji/io/factory.py" (currently line 68): name = parsed_url.scheme
The problem is that when your "url" has an underscore in its scheme, python does not interpret it as a scheme anymore and sets it to "None".
For example data_pool:stuff/stuff wont work for backups, as data_pool would not be interpreted as a scheme. However if I used data-pool it works.
Also I fear that a ":" is also allowed in Ceph - that would break the entire URL scheme. ( I am not sure on this and didn't test it )

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions