Skip to content

Commit 03b27c9

Browse files
author
Michael Myaskovsky
committed
fix default tests
1 parent f27e8d7 commit 03b27c9

File tree

4 files changed

+32
-5
lines changed

4 files changed

+32
-5
lines changed

macros/edr/data_monitoring/monitors_query/column_monitoring_query.sql

Lines changed: 27 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,33 @@
9494
),
9595

9696
column_metrics_unpivot as (
97-
{{ elementary.get_column_metrics_unpivot_query(column_metrics, column_obj, metric_name_to_type, timestamp_column, dimensions) }}
97+
{%- if column_metrics %}
98+
{% for metric_name, metric_type in metric_name_to_type.items() %}
99+
select
100+
{{ elementary.const_as_string(column_obj.name) }} as edr_column_name,
101+
bucket_start,
102+
bucket_end,
103+
{% if timestamp_column %}
104+
{{ elementary.timediff("hour", "bucket_start", "bucket_end") }} as bucket_duration_hours,
105+
{% else %}
106+
{{ elementary.null_int() }} as bucket_duration_hours,
107+
{% endif %}
108+
{% if dimensions | length > 0 %}
109+
{{ elementary.const_as_string(elementary.join_list(dimensions, separator='; ')) }} as dimension,
110+
{{ elementary.list_concat_with_separator(prefixed_dimensions, separator='; ') }} as dimension_value,
111+
{% else %}
112+
{{ elementary.null_string() }} as dimension,
113+
{{ elementary.null_string() }} as dimension_value,
114+
{% endif %}
115+
{{ elementary.edr_cast_as_float(metric_type) }} as metric_value,
116+
{{ elementary.edr_cast_as_string(elementary.edr_quote(metric_name)) }} as metric_name,
117+
{{ elementary.edr_cast_as_string(elementary.edr_quote(metric_type)) }} as metric_type
118+
from column_metrics where {{ metric_type }} is not null
119+
{% if not loop.last %} union all {% endif %}
120+
{%- endfor %}
121+
{%- else %}
122+
{{ elementary.empty_table([('edr_column_name','string'),('bucket_start','timestamp'),('bucket_end','timestamp'),('bucket_duration_hours','int'),('dimension','string'),('dimension_value','string'),('metric_name','string'),('metric_type','string'),('metric_value','float')]) }}
123+
{%- endif %}
98124
),
99125

100126
metrics_final as (

macros/edr/data_monitoring/monitors_query/dimension_monitoring_query.sql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,9 @@
202202
{{ elementary.null_timestamp() }} as bucket_start,
203203
bucket_end,
204204
{{ elementary.null_int() }} as bucket_duration_hours,
205-
{{ elementary.null_string() }} as dimension,
206-
{{ elementary.null_string() }} as dimension_value,
205+
206+
{{ elementary.const_as_string(dimensions_string) }} as dimension,
207+
dimension_value,
207208
{{ elementary.dict_to_quoted_json(metric_properties) }} as metric_properties
208209
from row_count
209210
)

macros/edr/tests/test_dimension_anomalies.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% test dimension_anomalies(model, dimensions, timestamp_column, where_expression, anomaly_sensitivity, anomaly_direction, min_training_set_size, time_bucket, days_back, backfill_days, seasonality, sensitivity,ignore_small_changes, fail_on_zero, detection_delay, anomaly_exclude_metrics, detection_period, training_period, exclude_final_results) %}
22
{{ config(tags = ['elementary-tests']) }}
3-
{%- if execute and elementary.is_test_command()%}
3+
{%- if execute and elementary.is_test_command() and elementary.is_elementary_enabled() %}
44
{% set model_relation = elementary.get_model_relation_for_test(model, context["model"]) %}
55
{% if not model_relation %}
66
{{ exceptions.raise_compiler_error("Unsupported model: " ~ model ~ " (this might happen if you override 'ref' or 'source')") }}

macros/edr/tests/test_table_anomalies.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% test table_anomalies(model, table_anomalies, timestamp_column, where_expression, anomaly_sensitivity, anomaly_direction, min_training_set_size, time_bucket, days_back, backfill_days, seasonality, mandatory_params=none, event_timestamp_column=none, freshness_column=none, sensitivity=none, ignore_small_changes={"spike_failure_percent_threshold": none, "drop_failure_percent_threshold": none}, fail_on_zero=false, detection_delay=none, anomaly_exclude_metrics=none, detection_period=none, training_period=none) %}
22
{{ config(tags = ['elementary-tests']) }}
3-
{%- if execute and elementary.is_test_command() %}
3+
{%- if execute and elementary.is_test_command() and elementary.is_elementary_enabled() %}
44
{% set model_relation = elementary.get_model_relation_for_test(model, context["model"]) %}
55
{% if not model_relation %}
66
{{ exceptions.raise_compiler_error("The test has unsupported configuration, please contact Elementary support") }}

0 commit comments

Comments
 (0)