Fix databricks temp relations (#810)

* creating a view relation when creating a temp relation for databricks because dbt-databricks 1.10 now creates views only if the context of the model has language=sql but this macro also runs outside model context and then it fails.

* separating the create_intermediate_relation from the make_temp_table_relation, because we want different databricks behaviors in these cases

Author: GuyEshdat

macros/utils/table_operations/create_intermediate_relation.sql

@@ -1,5 +1,5 @@
 {% macro create_intermediate_relation(base_relation, rows, temporary, like_columns=none) %}
-    {% set int_relation = elementary.make_temp_table_relation(base_relation).incorporate(type='table') %}
+    {% set int_relation = elementary.edr_make_intermediate_relation(base_relation).incorporate(type='table') %}
 
     {% if not elementary.has_temp_table_support() %}
         {% set temporary = false %}
@@ -9,3 +9,21 @@
     {% do elementary.insert_rows(int_relation, rows, should_commit=false, chunk_size=elementary.get_config_var('dbt_artifacts_chunk_size')) %}
     {% do return(int_relation) %}
 {% endmacro %}
+
+{% macro edr_make_intermediate_relation(base_relation) %}
+    {% do return(adapter.dispatch("edr_make_intermediate_relation", "elementary")(base_relation)) %}
+{% endmacro %}
+
+{% macro default__edr_make_intermediate_relation(base_relation) %}
+    {% do return(elementary.make_temp_table_relation(base_relation)) %}
+{% endmacro %}
+
+{% macro databricks__edr_make_intermediate_relation(base_relation) %}
+    {% set tmp_identifier = elementary.table_name_with_suffix(base_relation.identifier, elementary.get_timestamped_table_suffix()) %}
+    {% set tmp_relation = api.Relation.create(
+        identifier=tmp_identifier,
+        schema=base_relation.schema,
+        database=base_relation.database,
+        type='table') %}
+    {% do return(tmp_relation) %}
+{% endmacro %}

macros/utils/table_operations/make_temp_relation.sql

@@ -17,7 +17,9 @@
 {% endmacro %}
 
 {% macro databricks__edr_make_temp_relation(base_relation, suffix) %}
-    {% do return(dbt.make_temp_relation(base_relation, suffix)) %}
+    {% set tmp_identifier = elementary.table_name_with_suffix(base_relation.identifier, suffix) %}
+    {% set tmp_relation = api.Relation.create(identifier=tmp_identifier, type='view') %}
+    {% do return(tmp_relation) %}
 {% endmacro %}
 
 --- VIEWS
@@ -43,16 +45,6 @@
     {% do return(elementary.edr_make_temp_relation(base_relation, suffix)) %}
 {% endmacro %}
 
-{% macro databricks__make_temp_table_relation(base_relation, suffix) %}
-    {% set tmp_identifier = elementary.table_name_with_suffix(base_relation.identifier, suffix) %}
-    {% set tmp_relation = api.Relation.create(
-        identifier=tmp_identifier,
-        schema=base_relation.schema,
-        database=base_relation.database,
-        type='table') %}
-    {% do return(tmp_relation) %}
-{% endmacro %}
-
 {% macro clickhouse__make_temp_table_relation(base_relation, suffix) %}
     {% set tmp_identifier = elementary.table_name_with_suffix(base_relation.identifier, suffix) %}
     {% set tmp_relation = api.Relation.create(