Skip to content

Commit 1bb0b7a

Browse files
committed
Added default llm model names
1 parent 07b8007 commit 1bb0b7a

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

macros/edr/tests/test_ai_data_validation.sql

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% test ai_data_validation(model, column_name, expectation_prompt, context='', llm_model_name='claude-3-5-sonnet') %}
1+
{% test ai_data_validation(model, column_name, expectation_prompt, context='', llm_model_name) %}
22
{{ config(tags = ['elementary-tests']) }}
33
{%- if execute and elementary.is_test_command() and elementary.is_elementary_enabled() %}
44
{% set model_relation = elementary.get_model_relation_for_test(model, context["model"]) %}
@@ -32,10 +32,13 @@
3232
{% endmacro %}
3333

3434
{% macro snowflake__generate_ai_data_validation_sql(model, column_name, prompt_template, llm_model_name) %}
35+
{% set default_snowflake_model_name = 'claude-3-5-sonnet' %}
36+
{% set chosen_llm_model_name = llm_model_name if llm_model_name is not none and llm_model_name|trim != '' else default_snowflake_model_name %}
37+
3538
with ai_data_validation_results as (
3639
select
3740
snowflake.cortex.complete(
38-
'{{ llm_model_name }}',
41+
'{{ chosen_llm_model_name }}',
3942
concat('{{ prompt_template }}', {{ column_name }}::text)
4043
) as result
4144
from {{ model }}
@@ -46,11 +49,14 @@
4649
where lower(result) like '%false%'
4750
{% endmacro %}
4851

49-
{% macro databricks__generate_ai_data_validation_sql(model, column_name, prompt_template, llm_model_name='databricks-meta-llama-3-3-70b-instruct') %}
52+
{% macro databricks__generate_ai_data_validation_sql(model, column_name, prompt_template, llm_model_name) %}
53+
{% set default_databricks_model_name = 'databricks-meta-llama-3-3-70b-instruct' %}
54+
{% set chosen_llm_model_name = llm_model_name if llm_model_name is not none and llm_model_name|trim != '' else default_databricks_model_name %}
55+
5056
with ai_data_validation_results as (
5157
select
5258
ai_query(
53-
'{{ llm_model_name }}',
59+
'{{ chosen_llm_model_name }}',
5460
concat('{{ prompt_template }}', cast({{ column_name }} as string))
5561
) as result
5662
from {{ model }}
@@ -62,12 +68,15 @@
6268
{% endmacro %}
6369

6470

65-
{% macro bigquery__generate_ai_data_validation_sql(model, column_name, prompt_template, llm_model_name='gemini-1.5-pro') %}
71+
{% macro bigquery__generate_ai_data_validation_sql(model, column_name, prompt_template, llm_model_name) %}
72+
{% set default_bigquery_model_name = 'gemini-1.5-pro' %}
73+
{% set chosen_llm_model_name = llm_model_name if llm_model_name is not none and llm_model_name|trim != '' else default_bigquery_model_name %}
74+
6675
with ai_data_validation_results as (
6776
SELECT ml_generate_text_llm_result as result
6877
FROM
6978
ML.GENERATE_TEXT(
70-
MODEL `{{model.schema}}.{{llm_model_name}}`,
79+
MODEL `{{model.schema}}.{{chosen_llm_model_name}}`,
7180
(
7281
SELECT
7382
CONCAT(

macros/edr/tests/test_unstructured_data_validation.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% test unstructured_data_validation(model, column_name, expectation_prompt, llm_model_name='claude-3-5-sonnet') %}
1+
{% test unstructured_data_validation(model, column_name, expectation_prompt, llm_model_name) %}
22
{{ config(tags = ['elementary-tests']) }}
33
{% set context = "You are a data validator specializing in validating unstructured data." %}
44
{{ return(elementary.test_ai_data_validation(model, column_name, expectation_prompt, context, llm_model_name)) }}

0 commit comments

Comments
 (0)