anomaly tests fixes

Author: haritamar

macros/edr/data_monitoring/anomaly_detection/get_anomaly_scores_query.sql

@@ -122,7 +122,7 @@
                 {{ metric_time_bucket_expr }} as metric_time_bucket,
                 {{ elementary.edr_cast_as_date(elementary.edr_date_trunc('day', metric_time_bucket_expr))}} as metric_date,
 
-                row_number() over (partition by id order by updated_at desc) as row_number
+                row_number() over (partition by id order by updated_at desc) as row_num
             from union_metrics
 
         ),
@@ -145,7 +145,7 @@
                 bucket_duration_hours,
                 updated_at
             from grouped_metrics_duplicates
-            where row_number = 1
+            where row_num = 1
         ),
 
         time_window_aggregation as (

macros/edr/data_monitoring/monitors/column_numeric_monitors.sql

@@ -34,6 +34,10 @@
     stddevPop(cast({{ column_name }} as {{ elementary.edr_type_float() }}))
 {%- endmacro %}
 
+{% macro dremio__standard_deviation(column_name) -%}
+    stddev_pop(cast({{ column_name }} as {{ elementary.edr_type_float() }}))
+{%- endmacro %}
+
 {% macro variance(column_name) -%}
     {{ return(adapter.dispatch('variance', 'elementary')(column_name)) }}
 {%- endmacro %}

macros/edr/data_monitoring/monitors_query/dimension_monitoring_query.sql

@@ -40,7 +40,6 @@
                 bucket_end,
                 dimension_value,
                 metric_value,
-                row_number () over (partition by dimension_value order by bucket_end desc) as row_number
             from {{ data_monitoring_metrics_relation }}
             where full_table_name = {{ full_table_name_str }}
                 and metric_name = {{ elementary.edr_quote(metric_name) }}
@@ -148,7 +147,6 @@
                 bucket_end,
                 dimension_value,
                 metric_value,
-                row_number () over (partition by dimension_value order by bucket_end desc) as row_number
             from {{ data_monitoring_metrics_relation }}
             where full_table_name = {{ full_table_name_str }}
                 and metric_name = {{ elementary.edr_quote(metric_name) }}

macros/edr/data_monitoring/monitors_query/table_monitoring_query.sql

@@ -269,7 +269,7 @@
     bucket_freshness_ranked as (
         select
             *,
-            row_number () over (partition by edr_bucket_end order by freshness is null, freshness desc) as row_number
+            row_number () over (partition by edr_bucket_end order by freshness is null, freshness desc) as row_num
         from bucket_all_freshness_metrics
     )
 
@@ -281,7 +281,7 @@
         {{ elementary.edr_cast_as_string('update_timestamp') }} as source_value,
         freshness as metric_value
     from bucket_freshness_ranked
-    where row_number = 1
+    where row_num = 1
 {% endmacro %}
 
 {% macro event_freshness_metric_query(metric, metric_properties) %}

macros/edr/tests/on_run_end/union_columns_snapshot_query.sql

@@ -9,7 +9,7 @@
             ),
             columns_snapshot_with_duplicates as (
                 select *,
-                    row_number() over (partition by column_state_id order by detected_at desc) as row_number
+                    row_number() over (partition by column_state_id order by detected_at desc) as row_num
                 from union_temp_columns_snapshot
             )
             select
@@ -21,7 +21,7 @@
                 is_new,
                 detected_at
             from columns_snapshot_with_duplicates
-            where row_number = 1
+            where row_num = 1
         {%- endset %}
         {{ return(union_temp_query) }}
     {%- endif %}

macros/edr/tests/on_run_end/union_metrics_query.sql

@@ -9,7 +9,7 @@
             ),
             metrics_with_duplicates as (
                 select *,
-                    row_number() over (partition by id order by updated_at desc) as row_number
+                    row_number() over (partition by id order by updated_at desc) as row_num
                 from union_temps_metrics
             )
             select
@@ -28,7 +28,7 @@
                 dimension_value,
                 metric_properties
             from metrics_with_duplicates
-            where row_number = 1
+            where row_num = 1
         {%- endset %}
         {{ return(union_temp_query) }}
     {%- endif %}

macros/edr/tests/test_utils/clean_elementary_test_tables.sql

@@ -48,11 +48,11 @@
 {% endmacro %}
 
 {% macro trino__get_clean_elementary_test_tables_queries(test_table_relations) %}
-    {% set queries = [] %}
-    {% for test_relation in test_table_relations %}
-        {% do queries.append("DROP TABLE IF EXISTS {}".format(test_relation)) %}
-    {% endfor %}
-    {% do return(queries) %}
+    {% do return(elementary.get_transactionless_clean_elementary_test_tables_queries(test_table_relations)) %}
+{% endmacro %}
+
+{% macro dremio__get_clean_elementary_test_tables_queries(test_table_relations) %}
+    {% do return(elementary.get_transactionless_clean_elementary_test_tables_queries(test_table_relations)) %}
 {% endmacro %}
 
 {% macro get_transaction_clean_elementary_test_tables_queries(test_table_relations) %}

macros/edr/tests/test_utils/get_anomaly_query.sql

@@ -62,7 +62,7 @@ case when
 
       final_results as (
         select
-            metric_value as value,
+            metric_value as {{ elementary.escape_reserved_keywords('value') }},
             training_avg as average,
             {# when there is an anomaly we would want to use the last value of the metric (lag), otherwise visually the expectations would look out of bounds #}
             case

macros/utils/sql_utils/escape_reserved_keywords.sql

@@ -14,7 +14,7 @@
 {% endmacro %}
 
 {% macro dremio__is_reserved_keywords(keyword) %}
-    {% do return(keyword in ['filter', 'sql', 'timestamp']) %}
+    {% do return(keyword in ['filter', 'sql', 'timestamp', 'value']) %}
 {% endmacro %}
 
 {% macro escape_keywords(keyword) %}