Skip to content

Commit 4c537c3

Browse files
committed
cr fixes
1 parent 2374288 commit 4c537c3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

integration_tests/dbt_project/macros/generate_schema_name.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
{% macro dremio__get_default_schema_name(custom_schema_name, node) -%}
2424
{%- set default_schema = target.schema if not is_datalake_node(node)
2525
else target.root_path -%}
26-
{%- if custom_schema_name is none -%}
26+
+ {%- if not custom_schema_name -%}
2727

2828
{% do return(default_schema) %}
2929

macros/utils/sql_utils/escape_reserved_keywords.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
{% endmacro %}
1515

1616
{% macro dremio__is_reserved_keywords(keyword) %}
17-
{% do return(keyword in ['filter', 'sql', 'timestamp', 'value', 'one', 'min', 'max', 'sum', 'count']) %}
17+
{% set cleaned_keyword = (keyword | trim | lower) %}
18+
{% do return(cleaned_keyword in ['filter', 'sql', 'timestamp', 'value', 'one', 'min', 'max', 'sum', 'count']) %}
1819
{% endmacro %}
1920

2021
{% macro escape_keywords(keyword) %}

0 commit comments

Comments
 (0)