Add tests and documentation for Athena quoting logic

- Add comprehensive tests for athena__get_clean_elementary_test_tables_queries macro
- Test database.schema.table and schema.table identifier formats
- Test special characters in table/schema names
- Add regression tests to ensure normal names still work
- Add explanatory comment about Athena backtick quoting requirement

Addresses automated GitHub comments requesting tests and documentation
for the Athena-specific quoting behavior in DROP TABLE statements.

Co-Authored-By: Yosef Arbiv <[email protected]>

Author: devin-ai-integration[bot]

integration_tests/dbt_project/macros/test_athena_quoting.sql

@@ -0,0 +1,43 @@
+{% macro test_athena_quoting_with_database() %}
+    {% set mock_relations = [
+        api.Relation.create(database='test_db', schema='test_schema', identifier='test_table')
+    ] %}
+    {% set queries = elementary.athena__get_clean_elementary_test_tables_queries(mock_relations) %}
+    {% for query in queries %}
+        {{ log(query, info=True) }}
+    {% endfor %}
+    {{ return('') }}
+{% endmacro %}
+
+{% macro test_athena_quoting_without_database() %}
+    {% set mock_relations = [
+        api.Relation.create(schema='test_schema', identifier='test_table')
+    ] %}
+    {% set queries = elementary.athena__get_clean_elementary_test_tables_queries(mock_relations) %}
+    {% for query in queries %}
+        {{ log(query, info=True) }}
+    {% endfor %}
+    {{ return('') }}
+{% endmacro %}
+
+{% macro test_athena_quoting_special_chars() %}
+    {% set mock_relations = [
+        api.Relation.create(database='test-db', schema='test_schema', identifier='test-table')
+    ] %}
+    {% set queries = elementary.athena__get_clean_elementary_test_tables_queries(mock_relations) %}
+    {% for query in queries %}
+        {{ log(query, info=True) }}
+    {% endfor %}
+    {{ return('') }}
+{% endmacro %}
+
+{% macro test_athena_quoting_normal_names() %}
+    {% set mock_relations = [
+        api.Relation.create(database='normal_db', schema='normal_schema', identifier='normal_table')
+    ] %}
+    {% set queries = elementary.athena__get_clean_elementary_test_tables_queries(mock_relations) %}
+    {% for query in queries %}
+        {{ log(query, info=True) }}
+    {% endfor %}
+    {{ return('') }}
+{% endmacro %}

integration_tests/tests/test_athena_quoting.py

@@ -0,0 +1,59 @@
+import pytest
+from dbt_project import DbtProject
+
+
+@pytest.mark.only_on_targets(["athena"])
+def test_athena_clean_elementary_test_tables_quoting(
+    test_id: str, dbt_project: DbtProject
+):
+    """Test that Athena DROP TABLE statements use proper backtick quoting."""
+
+    test_result = dbt_project.dbt_runner.run_operation(
+        "elementary_tests.test_athena_quoting_with_database", return_raw_edr_logs=True
+    )
+
+    assert any(
+        "DROP TABLE IF EXISTS `" in result for result in test_result
+    ), "Expected backtick quoting in DROP TABLE statement"
+    assert any(
+        "test_db.test_schema.test_table" in result for result in test_result
+    ), "Expected database.schema.table format"
+
+    test_result = dbt_project.dbt_runner.run_operation(
+        "elementary_tests.test_athena_quoting_without_database",
+        return_raw_edr_logs=True,
+    )
+
+    assert any(
+        "DROP TABLE IF EXISTS `" in result for result in test_result
+    ), "Expected backtick quoting in DROP TABLE statement"
+    assert any(
+        "test_schema.test_table" in result for result in test_result
+    ), "Expected schema.table format"
+
+    test_result = dbt_project.dbt_runner.run_operation(
+        "elementary_tests.test_athena_quoting_special_chars", return_raw_edr_logs=True
+    )
+
+    assert any(
+        "DROP TABLE IF EXISTS `" in result for result in test_result
+    ), "Expected backtick quoting for special characters"
+    assert any(
+        "test-db.test_schema.test-table" in result for result in test_result
+    ), "Expected special characters to be handled"
+
+
+@pytest.mark.only_on_targets(["athena"])
+def test_athena_quoting_regression(test_id: str, dbt_project: DbtProject):
+    """Regression test to ensure Athena quoting doesn't break existing functionality."""
+
+    test_result = dbt_project.dbt_runner.run_operation(
+        "elementary_tests.test_athena_quoting_normal_names", return_raw_edr_logs=True
+    )
+
+    assert any(
+        "DROP TABLE IF EXISTS `" in result for result in test_result
+    ), "Expected backtick quoting for normal names"
+    assert any(
+        "normal_db.normal_schema.normal_table" in result for result in test_result
+    ), "Expected normal names to work"

macros/edr/tests/test_utils/clean_elementary_test_tables.sql

@@ -40,6 +40,7 @@
 {% endmacro %}
 
 {% macro athena__get_clean_elementary_test_tables_queries(test_table_relations) %}
+    {# Athena requires explicit backtick quoting for DROP TABLE statements to avoid parsing errors (important-comment) #}
     {% set queries = [] %}
     {% for test_relation in test_table_relations %}
         {% if test_relation.database %}