Skip to content

Commit 4ea1afd

Browse files
Fix Elementary materialization override and disable_samples meta config access
- Add required flag for dbt 1.8+ materialization overrides - Enable materialization override by setting mute_ensure_materialization_override to false - Fix is_elementary_enabled() macro to properly check elementary_enabled var - Update disable_samples meta config access pattern to use bracket notation - Clean up debug logging code Co-Authored-By: Yosef Arbiv <[email protected]>
1 parent f521f09 commit 4ea1afd

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

integration_tests/dbt_project/dbt_project.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@ version: "1.0.0"
33
config-version: 2
44
profile: "elementary_tests"
55

6+
flags:
7+
require_explicit_package_overrides_for_builtin_materializations: false
8+
69
model-paths: ["models"]
710
analysis-paths: ["analyses"]
811
test-paths: ["tests"]
@@ -18,7 +21,7 @@ clean-targets: # directories to be removed by `dbt clean`
1821

1922
vars:
2023
debug_logs: "{{ env_var('DBT_EDR_DEBUG', False) }}"
21-
mute_ensure_materialization_override: true
24+
mute_ensure_materialization_override: false
2225

2326
models:
2427
elementary_tests:

macros/edr/materializations/test/test.sql

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,11 @@
5252
{% set result = materialization_macro() %}
5353
{% set sample_limit = elementary.get_config_var('test_sample_row_count') %}
5454

55-
{% set disable_samples = elementary.insensitive_get_dict_value(flattened_test, 'meta', {}).get('disable_samples', false) %}
55+
{% set disable_samples = false %}
56+
{% if "meta" in flattened_test and "disable_samples" in flattened_test["meta"] %}
57+
{% set disable_samples = flattened_test["meta"]["disable_samples"] %}
58+
{% endif %}
59+
5660
{% if disable_samples %}
5761
{% set sample_limit = 0 %}
5862
{% elif elementary.is_pii_table(flattened_test) %}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
{% macro is_elementary_enabled() %}
2+
{% if var('elementary_enabled', none) is not none %}
3+
{% do return(var('elementary_enabled')) %}
4+
{% endif %}
25
{% do return("elementary" in graph) %}
36
{% endmacro %}

0 commit comments

Comments
 (0)