Skip to content

Commit 8cc4050

Browse files
Remove redundant model PII tag checking logic
- Remove model-level PII tag checking from get_pii_columns_from_parent_model - This logic is handled elsewhere as noted by Yosef - Simplifies macro to focus only on column-level PII detection Co-Authored-By: Yosef Arbiv <[email protected]>
1 parent c5b9f45 commit 8cc4050

File tree

1 file changed

+1
-27
lines changed

1 file changed

+1
-27
lines changed

macros/edr/system/system_utils/get_pii_columns_from_parent_model.sql

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -35,33 +35,7 @@
3535
{% set pii_tags = (raw_pii_tags or []) | map('lower') | list %}
3636
{% endif %}
3737

38-
{# Check if the model itself has PII tags - if so, all columns are considered PII #}
39-
{% set _model_tags_sources = [
40-
parent_model.get('tags', []),
41-
parent_model.get('config', {}).get('tags', []),
42-
parent_model.get('meta', {}).get('tags', [])
43-
] %}
44-
{% set all_model_tags = [] %}
45-
{% for src in _model_tags_sources %}
46-
{% set tags_list = src if src is iterable and not (src is string) else [src] %}
47-
{% do all_model_tags.extend(tags_list) %}
48-
{% endfor %}
49-
{% set all_model_tags = all_model_tags | map('lower') | unique | list %}
50-
51-
{% for pii_tag in pii_tags %}
52-
{% if pii_tag in all_model_tags %}
53-
{# Model has PII tag, return all column names #}
54-
{% set column_nodes = parent_model.get("columns") %}
55-
{% if column_nodes %}
56-
{% for column_node in column_nodes.values() %}
57-
{% do pii_columns.append(column_node.get('name')) %}
58-
{% endfor %}
59-
{% endif %}
60-
{% do return(pii_columns) %}
61-
{% endif %}
62-
{% endfor %}
63-
64-
{# Model doesn't have PII tags, check individual columns #}
38+
{# Check individual columns for PII tags #}
6539
{% set column_nodes = parent_model.get("columns") %}
6640
{% if not column_nodes %}
6741
{% do return(pii_columns) %}

0 commit comments

Comments
 (0)