Skip to content

Commit bb75d82

Browse files
Add exclude_detection_period_from_training flag to column anomalies tests
Co-Authored-By: Yosef Arbiv <[email protected]>
1 parent e7c2488 commit bb75d82

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

macros/edr/tests/test_all_columns_anomalies.sql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% test all_columns_anomalies(model, column_anomalies, exclude_prefix, exclude_regexp, timestamp_column, where_expression, anomaly_sensitivity, anomaly_direction, min_training_set_size, time_bucket, days_back, backfill_days, seasonality, sensitivity,ignore_small_changes, fail_on_zero, detection_delay, anomaly_exclude_metrics, detection_period, training_period, dimensions) %}
1+
{% test all_columns_anomalies(model, column_anomalies, exclude_prefix, exclude_regexp, timestamp_column, where_expression, anomaly_sensitivity, anomaly_direction, min_training_set_size, time_bucket, days_back, backfill_days, seasonality, sensitivity,ignore_small_changes, fail_on_zero, detection_delay, anomaly_exclude_metrics, detection_period, training_period, dimensions, exclude_detection_period_from_training=false) %}
22
{{ config(tags = ['elementary-tests']) }}
33
{%- if execute and elementary.is_test_command() and elementary.is_elementary_enabled() %}
44
{% set model_relation = elementary.get_model_relation_for_test(model, elementary.get_test_model()) %}
@@ -37,7 +37,8 @@
3737
anomaly_exclude_metrics=anomaly_exclude_metrics,
3838
detection_period=detection_period,
3939
training_period=training_period,
40-
dimensions=dimensions) %}
40+
dimensions=dimensions,
41+
exclude_detection_period_from_training=exclude_detection_period_from_training) %>
4142

4243
{%- if not test_configuration %}
4344
{{ exceptions.raise_compiler_error("Failed to create test configuration dict for test `{}`".format(test_table_name)) }}

macros/edr/tests/test_column_anomalies.sql

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{% test column_anomalies(model, column_name, column_anomalies, timestamp_column, where_expression, anomaly_sensitivity, anomaly_direction, min_training_set_size, time_bucket, days_back, backfill_days, seasonality, sensitivity,ignore_small_changes, fail_on_zero, detection_delay, anomaly_exclude_metrics, detection_period, training_period, dimensions) %}
1+
{% test column_anomalies(model, column_name, column_anomalies, timestamp_column, where_expression, anomaly_sensitivity, anomaly_direction, min_training_set_size, time_bucket, days_back, backfill_days, seasonality, sensitivity,ignore_small_changes, fail_on_zero, detection_delay, anomaly_exclude_metrics, detection_period, training_period, dimensions, exclude_detection_period_from_training=false) %}
22
{{ config(tags = ['elementary-tests']) }}
33
{%- if execute and elementary.is_test_command() and elementary.is_elementary_enabled() %}
44
{% set model_relation = elementary.get_model_relation_for_test(model, elementary.get_test_model()) %}
@@ -36,7 +36,8 @@
3636
anomaly_exclude_metrics=anomaly_exclude_metrics,
3737
detection_period=detection_period,
3838
training_period=training_period,
39-
dimensions=dimensions) %}
39+
dimensions=dimensions,
40+
exclude_detection_period_from_training=exclude_detection_period_from_training) %}
4041

4142
{%- if not test_configuration %}
4243
{{ exceptions.raise_compiler_error("Failed to create test configuration dict for test `{}`".format(test_table_name)) }}

0 commit comments

Comments
 (0)