change job name

Author: haritamar

.github/workflows/test-warehouse.yml

@@ -53,12 +53,13 @@ env:
   TESTS_DIR: ${{ github.workspace }}/dbt-data-reliability/integration_tests
 
 jobs:
-  detect-fork:
+  # PRs from forks require approval, specifically with the "pull_request_target" event as it contains repo secrets.
+  check-if-requires-approval:
     runs-on: ubuntu-latest
     outputs:
       requires_approval: ${{ steps.set-output.outputs.requires_approval }}
     steps:
-      - name: Set fork output
+      - name: Set requires approval output
         id: set-output
         run: |
           if [[ "${{ github.event_name }}" == "pull_request_target" && "${{ github.event.pull_request.head.repo.full_name }}" != "${{ github.repository }}" ]]; then
@@ -69,9 +70,8 @@ jobs:
 
   test:
     runs-on: ubuntu-latest
-    needs: [detect-fork]
-    # PRs from forks require approval - so we use an environment that requires an approver from the team.
-    environment: ${{ (needs.detect-fork.outputs.requires_approval == 'true' && 'elementary_test_env') || '' }}
+    needs: [check-if-requires-approval]
+    environment: ${{ (needs.check-if-requires-approval.outputs.requires_approval == 'true' && 'elementary_test_env') || '' }}
     concurrency:
       # This is what eventually defines the schema name in the data platform.
       group: tests_${{ inputs.warehouse-type }}_dbt_${{ inputs.dbt-version }}_${{ github.head_ref || github.ref_name }}