Skip to content

Commit d7254af

Browse files
author
Michael Myaskovsky
committed
added comments on all skips
1 parent 43a5f5e commit d7254af

15 files changed

+55
-0
lines changed

integration_tests/tests/test_all_columns_anomalies.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ def test_anomalyless_all_columns_anomalies(test_id: str, dbt_project: DbtProject
2929
assert all([res["status"] == "pass" for res in test_results])
3030

3131

32+
# Anomalies currently not supported on ClickHouse
3233
@pytest.mark.skip_targets(["clickhouse"])
3334
def test_anomalous_all_columns_anomalies(test_id: str, dbt_project: DbtProject):
3435
utc_today = datetime.utcnow().date()
@@ -54,6 +55,7 @@ def test_anomalous_all_columns_anomalies(test_id: str, dbt_project: DbtProject):
5455
assert col_to_status == {"superhero": "fail", TIMESTAMP_COLUMN: "pass"}
5556

5657

58+
# Anomalies currently not supported on ClickHouse
5759
@pytest.mark.skip_targets(["clickhouse"])
5860
def test_all_columns_anomalies_with_where_expression(
5961
test_id: str, dbt_project: DbtProject

integration_tests/tests/test_anomalies_backfill_logic.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ def test_full_backfill_for_non_incremental_model(dbt_project: DbtProject, test_i
107107
}
108108

109109

110+
# Anomalies currently not supported on ClickHouse
110111
@pytest.mark.skip_targets(["clickhouse"])
111112
def test_partial_backfill_for_incremental_models(dbt_project: DbtProject, test_id: str):
112113
utc_today = datetime.utcnow().date()
@@ -154,6 +155,7 @@ def test_partial_backfill_for_incremental_models(dbt_project: DbtProject, test_i
154155
}
155156

156157

158+
# Anomalies currently not supported on ClickHouse
157159
@pytest.mark.skip_targets(["clickhouse"])
158160
def test_longer_backfill_in_case_of_a_gap(dbt_project: DbtProject, test_id: str):
159161
date_gap_size = 5
@@ -207,6 +209,7 @@ def test_longer_backfill_in_case_of_a_gap(dbt_project: DbtProject, test_id: str)
207209
}
208210

209211

212+
# Anomalies currently not supported on ClickHouse
210213
@pytest.mark.skip_targets(["clickhouse"])
211214
def test_full_backfill_if_metric_not_updated_for_a_long_time(
212215
dbt_project: DbtProject, test_id: str
@@ -267,6 +270,7 @@ def test_full_backfill_if_metric_not_updated_for_a_long_time(
267270
}
268271

269272

273+
# Anomalies currently not supported on ClickHouse
270274
@pytest.mark.skip_targets(["clickhouse"])
271275
def test_backfill_when_metric_doesnt_exist_back_enough(
272276
dbt_project: DbtProject, test_id: str
@@ -312,6 +316,7 @@ def test_backfill_when_metric_doesnt_exist_back_enough(
312316
}
313317

314318

319+
# Anomalies currently not supported on ClickHouse
315320
@pytest.mark.skip_targets(["clickhouse"])
316321
def test_backfill_with_middle_buckets_gap(dbt_project: DbtProject, test_id: str):
317322
utc_today = datetime.utcnow().date()
@@ -381,6 +386,7 @@ def test_backfill_with_middle_buckets_gap(dbt_project: DbtProject, test_id: str)
381386
}
382387

383388

389+
# Anomalies currently not supported on ClickHouse
384390
@pytest.mark.skip_targets(["clickhouse"])
385391
def test_bucket_size_not_aligned_with_days(dbt_project: DbtProject, test_id: str):
386392
"""

integration_tests/tests/test_anomalies_ranges.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ def get_latest_anomaly_test_points(dbt_project: DbtProject, test_id: str):
3434
return [json.loads(result["result_row"]) for result in results]
3535

3636

37+
# Anomalies currently not supported on ClickHouse
3738
@pytest.mark.skip_targets(["clickhouse"])
3839
def test_anomaly_ranges_are_valid(test_id: str, dbt_project: DbtProject):
3940
utc_today = datetime.utcnow().date()
@@ -68,6 +69,7 @@ def test_anomaly_ranges_are_valid(test_id: str, dbt_project: DbtProject):
6869
assert all([row["min_value"] == row["max_value"] for row in anomaly_test_points])
6970

7071

72+
# Anomalies currently not supported on ClickHouse
7173
@pytest.mark.skip_targets(["clickhouse"])
7274
def test_anomaly_ranges_are_valid_with_seasonality(
7375
test_id: str, dbt_project: DbtProject

integration_tests/tests/test_anomaly_exclude_metrics.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
time_bucket={"period": "hour", "count": 6},
2626
dates_step=timedelta(hours=6),
2727
)
28+
# Anomalies currently not supported on ClickHouse
2829
@pytest.mark.skip_targets(["clickhouse"])
2930
def test_exclude_specific_dates(
3031
test_id: str, dbt_project: DbtProject, time_bucket: dict, dates_step: timedelta
@@ -125,6 +126,7 @@ def test_exclude_specific_timestamps(test_id: str, dbt_project: DbtProject):
125126
assert test_result["status"] == "fail"
126127

127128

129+
# Anomalies currently not supported on ClickHouse
128130
@pytest.mark.skip_targets(["clickhouse"])
129131
def test_exclude_date_range(test_id: str, dbt_project: DbtProject):
130132
utc_today = datetime.utcnow().date()
@@ -161,6 +163,7 @@ def test_exclude_date_range(test_id: str, dbt_project: DbtProject):
161163
assert test_result["status"] == "fail"
162164

163165

166+
# Anomalies currently not supported on ClickHouse
164167
@pytest.mark.skip_targets(["clickhouse"])
165168
def test_exclude_by_metric_value(test_id: str, dbt_project: DbtProject):
166169
utc_today = datetime.utcnow().date()

integration_tests/tests/test_collect_metrics.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ def test_collect_no_timestamp_metrics(test_id: str, dbt_project: DbtProject):
9292
assert col_to_metric_names == EXPECTED_COL_TO_METRIC_NAMES
9393

9494

95+
# Anomalies currently not supported on ClickHouse
9596
@pytest.mark.skip_targets(["clickhouse"])
9697
def test_collect_group_by_metrics(test_id: str, dbt_project: DbtProject):
9798
utc_today = datetime.utcnow().date()

integration_tests/tests/test_column_anomalies.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def test_anomalyless_column_anomalies(test_id: str, dbt_project: DbtProject):
3030
assert test_result["status"] == "pass"
3131

3232

33+
# Anomalies currently not supported on ClickHouse
3334
@pytest.mark.skip_targets(["clickhouse"])
3435
def test_anomalyless_no_timestamp_column_anomalies(
3536
test_id: str, dbt_project: DbtProject
@@ -51,6 +52,7 @@ def test_anomalyless_no_timestamp_column_anomalies(
5152
assert test_result["status"] == "pass"
5253

5354

55+
# Anomalies currently not supported on ClickHouse
5456
@pytest.mark.skip_targets(["clickhouse"])
5557
def test_anomalous_column_anomalies(test_id: str, dbt_project: DbtProject):
5658
utc_today = datetime.utcnow().date()
@@ -75,6 +77,7 @@ def test_anomalous_column_anomalies(test_id: str, dbt_project: DbtProject):
7577
assert test_result["status"] == "fail"
7678

7779

80+
# Anomalies currently not supported on ClickHouse
7881
@pytest.mark.skip_targets(["clickhouse"])
7982
def test_column_anomalies_with_where_parameter(test_id: str, dbt_project: DbtProject):
8083
utc_today = datetime.utcnow().date()
@@ -176,6 +179,7 @@ def test_column_anomalies_with_timestamp_as_sql_expression(
176179
drop_failure_percent_threshold=5,
177180
metric_value=1,
178181
)
182+
# Anomalies currently not supported on ClickHouse
179183
@pytest.mark.skip_targets(["clickhouse"])
180184
def test_volume_anomaly_static_data_drop(
181185
test_id: str,
@@ -241,6 +245,7 @@ def test_anomalyless_column_anomalies_group(test_id: str, dbt_project: DbtProjec
241245
assert test_result["status"] == "pass"
242246

243247

248+
# Anomalies currently not supported on ClickHouse
244249
@pytest.mark.skip_targets(["clickhouse"])
245250
def test_column_anomalies_group_by(test_id: str, dbt_project: DbtProject):
246251
utc_today = datetime.utcnow().date()
@@ -295,6 +300,7 @@ def test_column_anomalies_group_by(test_id: str, dbt_project: DbtProject):
295300
assert test_result["failures"] == 2
296301

297302

303+
# Anomalies currently not supported on ClickHouse
298304
@pytest.mark.skip_targets(["clickhouse"])
299305
def test_anomalyless_column_anomalies_group_by_none_dimension(
300306
test_id: str, dbt_project: DbtProject
@@ -340,6 +346,7 @@ def test_anomalyless_column_anomalies_group_by_none_dimension(
340346
assert test_result["failures"] == 2
341347

342348

349+
# Anomalies currently not supported on ClickHouse
343350
@pytest.mark.skip_targets(["clickhouse"])
344351
def test_anomalyless_column_anomalies_group_by_multi(
345352
test_id: str, dbt_project: DbtProject
@@ -392,6 +399,7 @@ def test_anomalyless_column_anomalies_group_by_multi(
392399
assert test_result["failures"] == 3
393400

394401

402+
# Anomalies currently not supported on ClickHouse
395403
@pytest.mark.skip_targets(["clickhouse"])
396404
def test_anomalyless_column_anomalies_group_by_description(
397405
test_id: str, dbt_project: DbtProject
@@ -427,6 +435,7 @@ def test_anomalyless_column_anomalies_group_by_description(
427435
assert "not enough data" not in test_result["test_results_description"].lower()
428436

429437

438+
# Anomalies currently not supported on ClickHouse
430439
@pytest.mark.skip_targets(["clickhouse"])
431440
def test_anomalous_boolean_column_anomalies(test_id: str, dbt_project: DbtProject):
432441
utc_today = datetime.utcnow().date()

integration_tests/tests/test_dbt_artifacts/test_artifacts.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ def test_artifacts_caching(dbt_project: DbtProject):
2323
assert first_row == second_row, "Artifacts are not cached at the on-run-end."
2424

2525

26+
# Artifacts updating currently not supported on ClickHouse
2627
@pytest.mark.skip_targets(["clickhouse"])
2728
def test_artifacts_updating(dbt_project: DbtProject):
2829
# Disabled by default in the tests for performance reasons.

integration_tests/tests/test_dimension_anomalies.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ def test_dimension_anomalies_with_timestamp_as_sql_expression(
6969
assert test_result["status"] == "pass"
7070

7171

72+
# Anomalies currently not supported on ClickHouse
7273
@pytest.mark.skip_targets(["clickhouse"])
7374
def test_anomalous_dimension_anomalies(test_id: str, dbt_project: DbtProject):
7475
utc_today = datetime.utcnow().date()
@@ -101,6 +102,7 @@ def test_anomalous_dimension_anomalies(test_id: str, dbt_project: DbtProject):
101102
assert anomaly_test_points[0]["dimension_value"] == "Superman"
102103

103104

105+
# Anomalies currently not supported on ClickHouse
104106
@pytest.mark.skip_targets(["clickhouse"])
105107
def test_dimensions_anomalies_with_where_parameter(
106108
test_id: str, dbt_project: DbtProject
@@ -147,6 +149,7 @@ def test_dimensions_anomalies_with_where_parameter(
147149
assert test_result["status"] == "fail"
148150

149151

152+
# Anomalies currently not supported on ClickHouse
150153
@pytest.mark.skip_targets(["clickhouse"])
151154
def test_dimension_anomalies_with_timestamp_exclude_final_results(
152155
test_id: str, dbt_project: DbtProject

integration_tests/tests/test_event_freshness_anomalies.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ def test_anomalyless_event_freshness(test_id: str, dbt_project: DbtProject):
3030
assert result["status"] == "pass"
3131

3232

33+
# Anomalies currently not supported on ClickHouse
3334
@pytest.mark.skip_targets(["clickhouse"])
3435
def test_stop_event_freshness(test_id: str, dbt_project: DbtProject):
3536
anomaly_date = datetime.now() - timedelta(days=2)
@@ -52,6 +53,7 @@ def test_stop_event_freshness(test_id: str, dbt_project: DbtProject):
5253
assert result["status"] == "fail"
5354

5455

56+
# Anomalies currently not supported on ClickHouse
5557
@pytest.mark.skip_targets(["clickhouse"])
5658
def test_slower_rate_event_freshness(test_id: str, dbt_project: DbtProject):
5759
# To avoid races, set the "custom_started_at" to the beginning of the day

integration_tests/tests/test_exposure_schema_validity.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ def test_exposure_schema_validity_no_exposures(test_id: str, dbt_project: DbtPro
5050
assert test_result["status"] == "pass"
5151

5252

53+
# Schema validity currently not supported on ClickHouse
5354
@pytest.mark.skip_targets(["spark", "clickhouse"])
5455
def test_exposure_schema_validity_correct_columns_and_types(
5556
test_id: str, dbt_project: DbtProject
@@ -115,6 +116,7 @@ def test_exposure_schema_validity_correct_columns_and_invalid_type(
115116
assert test_result["status"] == "fail"
116117

117118

119+
# Schema validity currently not supported on ClickHouse
118120
@pytest.mark.skip_targets(["spark", "clickhouse"])
119121
def test_exposure_schema_validity_invalid_type_name_present_in_error(
120122
test_id: str, dbt_project: DbtProject

0 commit comments

Comments
 (0)