Merge pull request #1971 from elementary-data/ele-4832-full-source-name-in-freshness-alerts

ofek1weiss · web-flow · commit 13697e902829 · 2025-07-28T17:41:43.000+03:00
full source name in freshness alerts
diff --git a/elementary/monitor/alerts/source_freshness_alert.py b/elementary/monitor/alerts/source_freshness_alert.py
@@ -154,9 +154,16 @@ def error_message(self) -> str:
 
     @property
     def summary(self) -> str:
+        source_fqn = ".".join(
+            [
+                part
+                for part in [self.database_name, self.schema_name, self.identifier]
+                if part
+            ]
+        )
         if self.original_status == "runtime error":
-            return f'Failed to calculate the source freshness of "{self.source_name}"'
-        return f'Freshness exceeded the acceptable times on source "{self.source_name}"'
+            return f'Failed to calculate the source freshness of "{source_fqn}"'
+        return f'Freshness exceeded the acceptable times on source "{source_fqn}"'
 
     def get_report_link(self) -> Optional[ReportLinkData]:
         return get_test_runs_link(self.report_url, self.source_freshness_execution_id)
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-False_message-False_tags-True_owners-True_path-True_error-True_suppression-False_env-False.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-False_message-False_tags-True_owners-True_path-True_error-True_suppression-False_env-False.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
+              "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-False_message-True_tags-True_owners-True_path-False_error-True_suppression-False_env-True.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-False_message-True_tags-True_owners-True_path-False_error-True_suppression-False_env-True.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
+              "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-True_message-False_tags-False_owners-False_path-False_error-False_suppression-True_env-False.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-True_message-False_tags-False_owners-False_path-False_error-False_suppression-True_env-False.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
+              "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-True_message-False_tags-True_owners-True_path-True_error-False_suppression-True_env-False.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-True_message-False_tags-True_owners-True_path-True_error-False_suppression-True_env-False.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
+              "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-True_message-True_tags-False_owners-False_path-True_error-True_suppression-True_env-True.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-error_link-True_message-True_tags-False_owners-False_path-True_error-True_suppression-True_env-True.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",
+              "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-False_message-False_tags-False_owners-False_path-False_error-False_suppression-False_env-False.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-False_message-False_tags-False_owners-False_path-False_error-False_suppression-False_env-False.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
+              "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-False_message-True_tags-True_owners-False_path-False_error-True_suppression-True_env-True.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-False_message-True_tags-True_owners-False_path-False_error-True_suppression-True_env-True.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
+              "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-True_message-False_tags-True_owners-False_path-True_error-False_suppression-True_env-True.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-True_message-False_tags-True_owners-False_path-True_error-False_suppression-True_env-True.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
+              "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-True_message-True_tags-False_owners-True_path-False_error-True_suppression-False_env-True.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-True_message-True_tags-False_owners-True_path-False_error-True_suppression-False_env-True.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
+              "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-True_message-True_tags-True_owners-True_path-True_error-True_suppression-True_env-True.json b/tests/unit/alerts/alert_messages/fixtures/adaptive_card/source_freshness_alert_status-runtime error_link-True_message-True_tags-True_owners-True_path-True_error-True_suppression-True_env-True.json
@@ -10,7 +10,7 @@
           "items": [
             {
               "type": "TextBlock",
-              "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\"",
+              "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\"",
               "weight": "bolder",
               "size": "large",
               "wrap": true
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-False_message-False_tags-True_owners-True_path-True_error-True_suppression-False_env-False.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-False_message-False_tags-True_owners-True_path-True_error-True_suppression-False_env-False.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
+        "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-False_message-True_tags-True_owners-True_path-False_error-True_suppression-False_env-True.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-False_message-True_tags-True_owners-True_path-False_error-True_suppression-False_env-True.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
+        "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-True_message-False_tags-False_owners-False_path-False_error-False_suppression-True_env-False.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-True_message-False_tags-False_owners-False_path-False_error-False_suppression-True_env-False.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
+        "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-True_message-False_tags-True_owners-True_path-True_error-False_suppression-True_env-False.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-True_message-False_tags-True_owners-True_path-True_error-False_suppression-True_env-False.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
+        "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-True_message-True_tags-False_owners-False_path-True_error-True_suppression-True_env-True.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-error_link-True_message-True_tags-False_owners-False_path-True_error-True_suppression-True_env-True.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Error: Freshness exceeded the acceptable times on source \"test_source\""
+        "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-False_message-False_tags-False_owners-False_path-False_error-False_suppression-False_env-False.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-False_message-False_tags-False_owners-False_path-False_error-False_suppression-False_env-False.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
+        "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-False_message-True_tags-True_owners-False_path-False_error-True_suppression-True_env-True.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-False_message-True_tags-True_owners-False_path-False_error-True_suppression-True_env-True.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
+        "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-True_message-False_tags-True_owners-False_path-True_error-False_suppression-True_env-True.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-True_message-False_tags-True_owners-False_path-True_error-False_suppression-True_env-True.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
+        "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-True_message-True_tags-False_owners-True_path-False_error-True_suppression-False_env-True.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-True_message-True_tags-False_owners-True_path-False_error-True_suppression-False_env-True.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
+        "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-True_message-True_tags-True_owners-True_path-True_error-True_suppression-True_env-True.json b/tests/unit/alerts/alert_messages/fixtures/block_kit/source_freshness_alert_status-runtime error_link-True_message-True_tags-True_owners-True_path-True_error-True_suppression-True_env-True.json
@@ -4,7 +4,7 @@
       "type": "header",
       "text": {
         "type": "plain_text",
-        "text": "Runtime Error: Failed to calculate the source freshness of \"test_source\""
+        "text": "Runtime Error: Failed to calculate the source freshness of \"test_db.test_schema.test_identifier\""
       }
     },
     {
diff --git a/tests/unit/alerts/alert_messages/test_alert_utils.py b/tests/unit/alerts/alert_messages/test_alert_utils.py
@@ -272,6 +272,8 @@ def build_base_source_freshness_alert_model(
     return SourceFreshnessAlertModel(
         id="test_id",
         source_name="test_source",
+        database_name="test_db",
+        schema_name="test_schema",
         identifier="test_identifier",
         original_status=status,
         path=path,

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`"items": [`
`11`	`11`	`{`
`12`	`12`	`"type": "TextBlock",`
`13`		`- "text": "Error: Freshness exceeded the acceptable times on source \"test_source\"",`
	`13`	`+ "text": "Error: Freshness exceeded the acceptable times on source \"test_db.test_schema.test_identifier\"",`
`14`	`14`	`"weight": "bolder",`
`15`	`15`	`"size": "large",`
`16`	`16`	`"wrap": true`