Skip to content

Commit af93af5

Browse files
committed
Handle missing asset name in test alert message generation
- Updated `get_alert_title()` method to generate concise alert messages when asset name is not available
1 parent 912546c commit af93af5

9 files changed

+18
-10
lines changed

elementary/monitor/alerts/test_alert.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,16 @@ def summary(self) -> str:
173173
)
174174

175175
if self.test_type == "schema_change":
176-
return f"{self.test_sub_type_display_name} on {asset_name}"
177-
return f'"{self.concise_name}" test failed on {asset_name}'
176+
return (
177+
f"{self.test_sub_type_display_name} on {asset_name}"
178+
if asset_name
179+
else self.test_sub_type_display_name
180+
)
181+
return (
182+
f'"{self.concise_name}" test failed on {asset_name}'
183+
if asset_name
184+
else f'"{self.concise_name}" test failed'
185+
)
178186

179187
def get_report_link(self) -> Optional[ReportLinkData]:
180188
return get_test_runs_link(self.report_url, self.elementary_unique_id)

tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-False_table-False_error-False_sample-False_env-False.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"items": [
1111
{
1212
"type": "TextBlock",
13-
"text": "\"test_short_name\" test failed on ",
13+
"text": "\"test_short_name\" test failed",
1414
"weight": "bolder",
1515
"size": "large",
1616
"wrap": true

tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-error_link-False_description-True_tags-False_owners-True_table-False_error-True_sample-False_env-True.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"items": [
1111
{
1212
"type": "TextBlock",
13-
"text": "Error: \"test_short_name\" test failed on ",
13+
"text": "Error: \"test_short_name\" test failed",
1414
"weight": "bolder",
1515
"size": "large",
1616
"wrap": true

tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-fail_link-False_description-False_tags-False_owners-False_table-False_error-False_sample-False_env-False.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"items": [
1111
{
1212
"type": "TextBlock",
13-
"text": "Failure: \"test_short_name\" test failed on ",
13+
"text": "Failure: \"test_short_name\" test failed",
1414
"weight": "bolder",
1515
"size": "large",
1616
"wrap": true

tests/unit/alerts/alert_messages/fixtures/adaptive_card_elementary_test_alert_status-None_link-False_description-False_tags-False_owners-False_table-False_error-False_sample-False_anomaly-False_env-False.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"items": [
1111
{
1212
"type": "TextBlock",
13-
"text": "Generic on ",
13+
"text": "Generic",
1414
"weight": "bolder",
1515
"size": "large",
1616
"wrap": true

tests/unit/alerts/alert_messages/fixtures/adaptive_card_elementary_test_alert_status-None_link-False_description-True_tags-False_owners-True_table-False_error-True_sample-False_anomaly-True_env-True.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"items": [
1111
{
1212
"type": "TextBlock",
13-
"text": "\"test_short_name\" test failed on ",
13+
"text": "\"test_short_name\" test failed",
1414
"weight": "bolder",
1515
"size": "large",
1616
"wrap": true

tests/unit/alerts/alert_messages/fixtures/adaptive_card_elementary_test_alert_status-error_link-True_description-True_tags-False_owners-False_table-False_error-True_sample-False_anomaly-True_env-True.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"items": [
1111
{
1212
"type": "TextBlock",
13-
"text": "Error: \"test_short_name\" test failed on ",
13+
"text": "Error: \"test_short_name\" test failed",
1414
"weight": "bolder",
1515
"size": "large",
1616
"wrap": true

tests/unit/alerts/alert_messages/fixtures/adaptive_card_elementary_test_alert_status-fail_link-False_description-False_tags-False_owners-False_table-False_error-False_sample-False_anomaly-False_env-False.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"items": [
1111
{
1212
"type": "TextBlock",
13-
"text": "Generic on ",
13+
"text": "Generic",
1414
"weight": "bolder",
1515
"size": "large",
1616
"wrap": true

tests/unit/alerts/alert_messages/fixtures/adaptive_card_elementary_test_alert_status-warn_link-False_description-True_tags-False_owners-True_table-False_error-True_sample-False_anomaly-True_env-False.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"items": [
1111
{
1212
"type": "TextBlock",
13-
"text": "Warning: \"test_short_name\" test failed on ",
13+
"text": "Warning: \"test_short_name\" test failed",
1414
"weight": "bolder",
1515
"size": "large",
1616
"wrap": true

0 commit comments

Comments
 (0)