Skip to content

Commit b5870a3

Browse files
MikaKermanMikaKerman
committed
Updated get_details_blocks() to always include tags, owners, and subscribers
- Added fallback text for empty lists to ensure consistent message formatting
1 parent 7baf655 commit b5870a3

File tree

2,703 files changed

+20957
-36
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,703 files changed

+20957
-36
lines changed

‎elementary/monitor/alerts/alert_messages/test_alert_message.py‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -148,12 +148,13 @@ def get_details_blocks(
148148
facts.append(("Table", table))
149149
if column:
150150
facts.append(("Column", column))
151-
if tags:
152-
facts.append(("Tags", ", ".join(tags or [])))
153-
if owners:
154-
facts.append(("Owners", ", ".join(owners or [])))
155-
if subscribers:
156-
facts.append(("Subscribers", ", ".join(subscribers or [])))
151+
152+
facts.append(("Tags", ", ".join(tags) if tags else "No tags"))
153+
facts.append(("Owners", ", ".join(owners) if owners else "No owners"))
154+
facts.append(
155+
("Subscribers", ", ".join(subscribers) if subscribers else "No subscribers")
156+
)
157+
157158
if description:
158159
facts.append(("Description", description))
159160
if path:

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-False_table-True_error-False_sample-False.json‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,18 @@
4040
{
4141
"title": "Table",
4242
"value": "test_table"
43+
},
44+
{
45+
"title": "Tags",
46+
"value": "No tags"
47+
},
48+
{
49+
"title": "Owners",
50+
"value": "No owners"
51+
},
52+
{
53+
"title": "Subscribers",
54+
"value": "No subscribers"
4355
}
4456
]
4557
}

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-False_table-True_error-False_sample-True.json‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,18 @@
4040
{
4141
"title": "Table",
4242
"value": "test_table"
43+
},
44+
{
45+
"title": "Tags",
46+
"value": "No tags"
47+
},
48+
{
49+
"title": "Owners",
50+
"value": "No owners"
51+
},
52+
{
53+
"title": "Subscribers",
54+
"value": "No subscribers"
4355
}
4456
]
4557
}

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-False_table-True_error-True_sample-False.json‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,18 @@
4040
{
4141
"title": "Table",
4242
"value": "test_table"
43+
},
44+
{
45+
"title": "Tags",
46+
"value": "No tags"
47+
},
48+
{
49+
"title": "Owners",
50+
"value": "No owners"
51+
},
52+
{
53+
"title": "Subscribers",
54+
"value": "No subscribers"
4355
}
4456
]
4557
}

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-False_table-True_error-True_sample-True.json‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,18 @@
4040
{
4141
"title": "Table",
4242
"value": "test_table"
43+
},
44+
{
45+
"title": "Tags",
46+
"value": "No tags"
47+
},
48+
{
49+
"title": "Owners",
50+
"value": "No owners"
51+
},
52+
{
53+
"title": "Subscribers",
54+
"value": "No subscribers"
4355
}
4456
]
4557
}

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-True_table-False_error-False_sample-False.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,17 @@
3737
{
3838
"type": "FactSet",
3939
"facts": [
40+
{
41+
"title": "Tags",
42+
"value": "No tags"
43+
},
4044
{
4145
"title": "Owners",
4246
"value": "owner1, owner2"
47+
},
48+
{
49+
"title": "Subscribers",
50+
"value": "No subscribers"
4351
}
4452
]
4553
}

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-True_table-False_error-False_sample-True.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,17 @@
3737
{
3838
"type": "FactSet",
3939
"facts": [
40+
{
41+
"title": "Tags",
42+
"value": "No tags"
43+
},
4044
{
4145
"title": "Owners",
4246
"value": "owner1, owner2"
47+
},
48+
{
49+
"title": "Subscribers",
50+
"value": "No subscribers"
4351
}
4452
]
4553
}

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-True_table-False_error-True_sample-False.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,17 @@
3737
{
3838
"type": "FactSet",
3939
"facts": [
40+
{
41+
"title": "Tags",
42+
"value": "No tags"
43+
},
4044
{
4145
"title": "Owners",
4246
"value": "owner1, owner2"
47+
},
48+
{
49+
"title": "Subscribers",
50+
"value": "No subscribers"
4351
}
4452
]
4553
}

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-True_table-False_error-True_sample-True.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,17 @@
3737
{
3838
"type": "FactSet",
3939
"facts": [
40+
{
41+
"title": "Tags",
42+
"value": "No tags"
43+
},
4044
{
4145
"title": "Owners",
4246
"value": "owner1, owner2"
47+
},
48+
{
49+
"title": "Subscribers",
50+
"value": "No subscribers"
4351
}
4452
]
4553
}

‎tests/unit/alerts/alert_messages/fixtures/adaptive_card_dbt_test_alert_status-None_link-False_description-False_tags-False_owners-True_table-True_error-False_sample-False.json‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,17 @@
4141
"title": "Table",
4242
"value": "test_table"
4343
},
44+
{
45+
"title": "Tags",
46+
"value": "No tags"
47+
},
4448
{
4549
"title": "Owners",
4650
"value": "owner1, owner2"
51+
},
52+
{
53+
"title": "Subscribers",
54+
"value": "No subscribers"
4755
}
4856
]
4957
}

0 commit comments

Comments
 (0)