Skip to content

Commit b5cd157

Browse files
authored
Merge pull request #1875 from elementary-data/ele-4237-report-test-description-for-dbt-19
Enhance test result handling by adding test_description field
2 parents 1c55ea4 + c714714 commit b5cd157

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

elementary/monitor/api/tests/tests.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,10 @@ def _get_test_metadata_from_test_result_db_row(
378378
test_query=test_query,
379379
test_params=test_result_db_row.test_params,
380380
test_created_at=test_result_db_row.test_created_at,
381-
description=test_result_db_row.meta.get("description"),
381+
description=(
382+
test_result_db_row.test_description
383+
or test_result_db_row.meta.get("description")
384+
),
382385
result=result,
383386
configuration=configuration,
384387
test_tags=test_result_db_row.test_tags,

elementary/monitor/dbt_project/macros/base_queries/current_tests_run_results_query.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@
8282
elementary_test_results.result_rows,
8383
dbt_tests.original_path,
8484
dbt_tests.meta,
85+
dbt_tests.description as test_description,
8586
dbt_tests.package_name,
8687
dbt_tests.tags as test_tags,
8788
dbt_artifacts.meta as model_meta,

elementary/monitor/dbt_project/macros/get_test_results.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
test_results.test_type,
3131
test_results.test_sub_type,
3232
test_results.test_results_description,
33+
test_results.test_description,
3334
test_results.original_path,
3435
test_results.package_name,
3536
test_results.owners,

elementary/monitor/fetchers/tests/schema.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ class TestResultDBRowSchema(ExtendedBaseModel):
2828
test_type: str
2929
test_sub_type: str
3030
test_results_description: Optional[str]
31+
test_description: Optional[str]
3132
original_path: str
3233
owners: Optional[List[str]]
3334
model_owner: Optional[List[str]]

0 commit comments

Comments
 (0)