Ele 3893 alert rules operators #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 @MikaKerman |
…on_alert function
- Updated test cases in `test_alert_filters.py` to replace direct calls to individual filter functions with the new `filter_alerts` method. - Enhanced alert data structures to use `datetime` objects instead of string representations for timestamps. - Improved the handling of alert statuses by using the `AlertStatus` enum. - Adjusted test data to ensure consistency and correctness in the alert filtering logic.
…nd 'ALL' operator logic for value filtering.
…r 'IS_NOT' filter types across tags, owners, models, and statuses.
…ding logic in apply_filter function. Enhance unit tests to validate behavior of the new filter type in FilterSchema.
MikaKerman
force-pushed
the
ele-3893-alert-rules-operators
branch
from
5920f35 to
b965c08
Compare
ofek1weiss
reviewed
Dec 29, 2024
| alert_node_name = None | ||
| alert_type = AlertTypes(alert.type) | ||
| if alert_type is AlertTypes.TEST: | ||
| alert_node_name = alert.data.test_name # type: ignore[union-attr] |
Contributor
There was a problem hiding this comment.
i think you can remove this type ignore by adding type hints in line 32: alert_node_name: Optional[str] = None
Contributor
Author
There was a problem hiding this comment.
Apparently not :(
def _get_alert_node_name(alert: PendingAlertSchema) -> Optional[str]:
alert_node_name: Optional[str] = None
alert_type = AlertTypes(alert.type)
if alert_type is AlertTypes.TEST:
alert_node_name = alert.data.test_name
elementary/monitor/api/alerts/alert_filters.py:31: error: Item "ModelAlertDataSchema" of "Union[TestAlertDataSchema, ModelAlertDataSchema, SourceFreshnessAlertDataSchema]" has no attribute "test_name" [union-attr]
elementary/monitor/api/alerts/alert_filters.py:31: error: Item "SourceFreshnessAlertDataSchema" of "Union[TestAlertDataSchema, ModelAlertDataSchema, SourceFreshnessAlertDataSchema]" has no attribute "test_name" [union-attr]
It's from the earlier version.
|
|
||
| class StatusFilterSchema(FilterSchema): | ||
| class StatusFilterSchema(FilterSchema[Status]): | ||
| values: List[Status] |
Contributor
There was a problem hiding this comment.
you can remove the re-definition of values here
Contributor
Author
There was a problem hiding this comment.
I thought so too, but apparently not.
pydantic/pydantic#4171
|
|
||
| class ResourceTypeFilterSchema(FilterSchema): | ||
| class ResourceTypeFilterSchema(FilterSchema[ResourceType]): | ||
| values: List[ResourceType] |
Contributor
Author
There was a problem hiding this comment.
Commented above.
| else [] | ||
| ) | ||
|
|
||
| return ( |
Contributor
There was a problem hiding this comment.
move this to separate function
ofek1weiss
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null