Allow contributor PRs to run tests - CLI #1866
Conversation
|
👋 @haritamar |
| issues: | ||
| types: [closed] | ||
| pull_request: | ||
| pull_request_target: |
There was a problem hiding this comment.
The Pylon actions don't actually need an environment, since they don't need the PR code, just the PR details.
To be safe I actually removed the checkout which is unneeded.
haritamar
changed the title
| issues: | ||
| types: [closed] | ||
| pull_request: | ||
| pull_request_target: |
There was a problem hiding this comment.
In both repos we are checking: github.event_name == 'pull_request'. I don't think it will work.
There was a problem hiding this comment.
Good point, thanks!
.github/workflows/run-precommit.yml
Outdated
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| pull_request_target: |
There was a problem hiding this comment.
why do we need to change it for the pre-commit?
There was a problem hiding this comment.
Actually we really don't
I thought about that it's running code, but it's not using secrets so no issues here, changing back
haritamar
deleted the
ele-4203-make-it-possible-to-run-tests-on-contributor-prs
branch
* use pull_request_target + environment to allow running tests on contributor PRs * run-precommit should be on PR branch * a bit safer condition * CR fixes * no need for pull_request_target in precommit
No description provided.