-
Notifications
You must be signed in to change notification settings - Fork 203
Unlimit numpy #1963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlimit numpy #1963
Conversation
WalkthroughChanged the Changes
Sequence Diagram(s)Not applicable — no runtime control-flow or new feature introduced. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
👋 @CloutKhan |
arbiv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing due to this change
Keep numpy as a manually listed dependency (even though it should be a downstream dependency of dbt-core which is already listed) but unlimit it by giving it an any specifier.
|
It's been a while ~ I remember checking back when I made this that |
|
resolved in #2074 |
See #1962
Summary by CodeRabbit