Skip to content

Conversation

@CloutKhan
Copy link

@CloutKhan CloutKhan commented Jul 18, 2025

See #1962

Summary by CodeRabbit

  • Chores
    • Relaxed the project's numpy version requirement to allow any released version.
    • This may change dependency resolution or installation outcomes; no functional changes to the product's behavior are expected.

@CloutKhan CloutKhan had a problem deploying to elementary_test_env July 18, 2025 04:31 — with GitHub Actions Failure
@coderabbitai
Copy link

coderabbitai bot commented Jul 18, 2025

Walkthrough

Changed the numpy dependency specification in pyproject.toml from "<2.0.0" to "*". No other files or control flow were modified.

Changes

Cohort / File(s) Change Summary
Dependency version change
pyproject.toml
Updated numpy in [tool.poetry.dependencies] from "<2.0.0" to "*" (removed the upper-bound constraint).

Sequence Diagram(s)

Not applicable — no runtime control-flow or new feature introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Files to check: pyproject.toml (ensure only the numpy version spec was changed and formatting remained valid).

Poem

I munched the bounds, let versions roam,
A hop, a twitch — the pod feels home.
Loose as clover, paws on air,
NumPy now may go anywhere. 🐇🌱

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Unlimit numpy' directly and clearly describes the main change: removing the upper bound constraint from the numpy dependency specification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 87df3fe and dbe1e04.

📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

👋 @CloutKhan
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@arbiv arbiv had a problem deploying to elementary_test_env November 11, 2025 09:37 — with GitHub Actions Failure
Copy link
Contributor

@arbiv arbiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing due to this change

Keep numpy as a manually listed dependency (even though it should be a downstream dependency of dbt-core which is already listed) but unlimit it by giving it an any specifier.
@CloutKhan
Copy link
Author

It's been a while ~ I remember checking back when I made this that numpy would be included in the last several versions of dbt-core, but going back to look for it I can't actually see numpy listed in older versions of the core/setup.py in https://github.com/dbt-labs/dbt-core ~ so I've changed this from removing the dependency entirely to keeping it but unlimiting the specifier.

@vyagubov
Copy link
Contributor

I tried to fix a little bit differently: #2074
@arbiv could you review it, pls?

@arbiv
Copy link
Contributor

arbiv commented Dec 18, 2025

resolved in #2074

@arbiv arbiv closed this Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants