Remove deprecated test recommendations macro

[elazarlachkar]

null

Summary by CodeRabbit

• Removed Features
  • Removed the automated test recommendation system. This previously enabled intelligent test suggestions based on table metadata, dependencies, exposure data, and criticality analysis. The system included automatic timestamp column detection, table dependency tracking, and dynamic test argument generation for volume and freshness anomaly detection, as well as schema change detection tests.

[linear]

CORE-113 Remove deprecated DAGs

[coderabbitai]

Walkthrough

This pull request removes four interconnected dbt components of the tests_recommendation system: a macro for querying test recommendations and three models for table criticality assessment, timestamp column inference, and pending test generation.

Changes

Cohort / File(s)	Summary
Tests recommendation system removal elementary/monitor/dbt_project/macros/tests_recommendation/get_recommended_tests.sql, elementary/monitor/dbt_project/models/tests_recommendation/table_timestamp_columns.sql, elementary/monitor/dbt_project/models/tests_recommendation/tables_criticality.sql, elementary/monitor/dbt_project/models/tests_recommendation/test_recommendations.sql	Removed macro that queried test recommendations with a where_expression argument. Removed three interconnected models: table_timestamp_columns (timestamp column inference logic), tables_criticality (table metadata and dependency aggregation), and test_recommendations (pending test generation and enrichment with metadata).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–25 minutes

• Verify no orphaned dependencies: Confirm that no remaining code references the removed macro or models via dbt refs, sources, or direct calls.
• Check for related cleanup: Ensure that dependent downstream models, macros, or jobs that consumed the test_recommendations data have been properly addressed.
• Validate feature removal: Confirm this removal is intentional and represents a complete feature deprecation rather than an incomplete refactor.

Poem

🐰 Recommendations fade away,

Timestamp columns and tests reset,

Clean slate awaits the brand new day,

Old logic rests, we move ahead best!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title only refers to removing a macro, but the changeset removes 4 files including models and a macro.	Revise the title to reflect the broader scope: 'Remove deprecated test recommendations models and macro' or 'Remove deprecated test recommendations feature'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch core-113-remove-deprecated-dags

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between ef50438 and 2ed5914.

📒 Files selected for processing (4)

• elementary/monitor/dbt_project/macros/tests_recommendation/get_recommended_tests.sql (0 hunks)
• elementary/monitor/dbt_project/models/tests_recommendation/table_timestamp_columns.sql (0 hunks)
• elementary/monitor/dbt_project/models/tests_recommendation/tables_criticality.sql (0 hunks)
• elementary/monitor/dbt_project/models/tests_recommendation/test_recommendations.sql (0 hunks)

💤 Files with no reviewable changes (4)

• elementary/monitor/dbt_project/macros/tests_recommendation/get_recommended_tests.sql
• elementary/monitor/dbt_project/models/tests_recommendation/tables_criticality.sql
• elementary/monitor/dbt_project/models/tests_recommendation/test_recommendations.sql
• elementary/monitor/dbt_project/models/tests_recommendation/table_timestamp_columns.sql

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: code-quality
• GitHub Check: test / test

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

👋 @elazarlachkar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.