Skip to content

Conversation

@elazarlachkar
Copy link
Contributor

@elazarlachkar elazarlachkar commented Nov 24, 2025

Description

A recent change in the get_result_rows_agate macro added specific implementation for BigQuery.
The namespace of the dispatch call was elementary instead of elementary_cli, causing the error:

No macro named 'get_result_rows_agate' found within namespace: 'elementary'

Summary by CodeRabbit

  • Chores
    • Updated internal adapter dispatch mechanism to optimize system operations.

✏️ Tip: You can customize this high-level summary in your review settings.

@elazarlachkar elazarlachkar self-assigned this Nov 24, 2025
@linear
Copy link

linear bot commented Nov 24, 2025

@github-actions
Copy link
Contributor

👋 @elazarlachkar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Walkthrough

A macro in the dbt project is updated to dispatch to the 'elementary_cli' adapter instead of 'elementary', while preserving the original function signature and implementation logic.

Changes

Cohort / File(s) Summary
Adapter dispatcher update
elementary/monitor/dbt_project/macros/get_result_rows_agate.sql
Changed dispatcher from 'elementary' to 'elementary_cli' adapter

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that 'elementary_cli' adapter is the correct target and has the appropriate implementation
  • Confirm no dependent macros are affected by this dispatcher change

Poem

🐰 A hop, a skip, through adapters we go,
From 'elementary' to 'cli' in a single swift flow,
The result rows still flow, the function stays true,
Just redirecting the path to the work it must do! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: fixing a namespace issue in a macro call, which directly matches the PR's primary objective of correcting the dispatch namespace from 'elementary' to 'elementary_cli'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch core-121-fix-clis-macro-call

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 13bee34 and c5885f5.

📒 Files selected for processing (1)
  • elementary/monitor/dbt_project/macros/get_result_rows_agate.sql (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test / test
  • GitHub Check: code-quality
🔇 Additional comments (1)
elementary/monitor/dbt_project/macros/get_result_rows_agate.sql (1)

2-2: Correct namespace fix for macro dispatch.

Changing the dispatch namespace from 'elementary' to 'elementary_cli' aligns with the PR objective and should resolve the macro lookup error. The macro implementations (default__get_result_rows_agate and bigquery__get_result_rows_agate) are properly declared and will now be correctly discovered via the dispatch call.

Please confirm that the 'elementary_cli' namespace/project contains the adapter-specific macro implementations and is the correct target for this dispatch call.


Comment @coderabbitai help to get the list of available commands and usage tips.

@elazarlachkar elazarlachkar changed the title Fixed namespace of macro call Fix namespace of macro call Nov 24, 2025
@elazarlachkar elazarlachkar merged commit 68e48a0 into master Nov 24, 2025
7 checks passed
@elazarlachkar elazarlachkar deleted the core-121-fix-clis-macro-call branch November 24, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants