Skip to content

Conversation

@elazarlachkar
Copy link
Contributor

@elazarlachkar elazarlachkar commented Dec 4, 2025

Description

According to the docs:

dbt-athena-community was the community-maintained adapter until dbt Labs took over maintenance in late 2024. Both dbt-athena and dbt-athena-community are maintained by dbt Labs, but dbt-athena-community is now simply a wrapper on dbt-athena, published for backwards compatibility.

dbt-athena pacakge, however, contains only versions newer than 1.9.
For older versions (like 1.8 that is tested on CI) we need to install dbt-athena-community.

Tests

Made sure Test warehouse platform passes for Athena - link.

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to refine dbt package installation mappings for warehouse compatibility.

Note: This release contains no user-facing changes. It consists of internal infrastructure updates to build and test processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@elazarlachkar elazarlachkar self-assigned this Dec 4, 2025
@linear
Copy link

linear bot commented Dec 4, 2025

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

👋 @elazarlachkar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

Walkthrough

A single workflow configuration file is updated to add a mapping for the 'athena' warehouse-type to 'athena-community' dbt package during installation, alongside existing mappings for 'databricks_catalog' and generic warehouse-type fallback.

Changes

Cohort / File(s) Summary
Workflow Configuration
\.github/workflows/test-warehouse\.yml
Adds warehouse-type mapping ('athena' → 'athena-community') to dbt package installation logic

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that 'athena-community' is the correct dbt package name for Athena warehouse-type
  • Confirm the mapping syntax aligns with existing 'databricks_catalog' → 'databricks' pattern
  • Ensure no unintended side effects on other warehouse-type installations

Suggested reviewers

  • arbiv

Poem

🐰 A workflow's path now shines so bright,
With Athena mapped to community light,
No more confusion, packages aligned,
The warehouse dance is perfectly defined! 🎯

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Using community Athena pacakge in CI' clearly describes the main change: switching to use the community Athena package in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch core-180-fix-cli-ci-for-athena

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 34b875e and ef525a2.

📒 Files selected for processing (1)
  • .github/workflows/test-warehouse.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test
  • GitHub Check: test / test
  • GitHub Check: code-quality
🔇 Additional comments (2)
.github/workflows/test-warehouse.yml (2)

124-124: Correctly maps Athena to athena-community package for older dbt versions.

The change appropriately handles the dbt version compatibility issue where dbt-athena is only available for versions >1.9. The conditional expression correctly maps athenaathena-community while preserving the existing databricks_catalogdatabricks mapping and allowing other warehouse types to use their default names.


129-129: Verify Elementary extras are consistent with dbt package installation.

Line 124 maps athena to athena-community, but line 129 only maps databricks_catalog to databricks. When installing Elementary with the athena extra, verify that the optional dependencies resolve correctly with dbt-athena-community for older dbt versions. If Elementary's athena extra has strict version constraints on dbt-athena, line 129 may need an analogous mapping.


Comment @coderabbitai help to get the list of available commands and usage tips.

@elazarlachkar elazarlachkar merged commit 4bc7494 into master Dec 4, 2025
6 checks passed
@elazarlachkar elazarlachkar deleted the core-180-fix-cli-ci-for-athena branch December 4, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants