Skip to content

Conversation

@elazarlachkar
Copy link
Contributor

@elazarlachkar elazarlachkar commented Dec 7, 2025

null

Summary by CodeRabbit

  • Chores
    • Updated dependency management to use a published package version (0.21.0) instead of a development source.

✏️ Tip: You can customize this high-level summary in your review settings.

@elazarlachkar elazarlachkar self-assigned this Dec 7, 2025
@linear
Copy link

linear bot commented Dec 7, 2025

CORE-60 OSS Version

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

👋 @elazarlachkar
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in this pull request.

@coderabbitai
Copy link

coderabbitai bot commented Dec 7, 2025

Walkthrough

This PR replaces the git-based dependency on elementary-data/dbt-data-reliability with the published dbt package elementary-data/elementary version 0.21.0, updating both the package declaration and lock file accordingly.

Changes

Cohort / File(s) Change Summary
Dependency Updates
elementary/monitor/dbt_project/packages.yml, elementary/monitor/dbt_project/package-lock.yml
Replaced git-sourced dependency on elementary-data/dbt-data-reliability with published dbt package elementary-data/elementary v0.21.0; updated package declaration and corresponding lock file entry with new sha1_hash.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that elementary-data/elementary v0.21.0 contains all required functionality from the previous git revision
  • Confirm compatibility with existing dbt_utils constraint
  • Validate that the transition from git-based to published package works without breaking changes

Possibly related PRs

  • #2024: Performs the same dependency swap from git-based dbt-data-reliability to published elementary package, but targets v0.20.0
  • #2003: Directly reverses this change by switching from published elementary package back to a git-based dbt-data-reliability reference
  • #1985: Related dependency update exchanging between git-based and published elementary package versions

Suggested reviewers

  • ofek1weiss

Poem

🐰 From git revisions wild and free,
To published packages, version spree!
Elementary 0.21 now takes the stage,
A cleaner way to turn the page! 📦✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Upgrade dbt package to 0.21.0' directly and clearly summarizes the main change—upgrading the elementary-data/elementary package from a git-based dependency to version 0.21.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch core-60-oss-version-0.21.0

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4bc7494 and 28a0ce0.

📒 Files selected for processing (2)
  • elementary/monitor/dbt_project/package-lock.yml (1 hunks)
  • elementary/monitor/dbt_project/packages.yml (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-19T09:03:56.968Z
Learnt from: arbiv
Repo: elementary-data/elementary PR: 1937
File: elementary/clients/dbt/databricks_patch.py:99-124
Timestamp: 2025-06-19T09:03:56.968Z
Learning: For Databricks compatibility patches in elementary, prefer simple and permissive approaches over strict version checking. The patch should apply when the target module is available, regardless of version, as the defensive programming with exception handling and fallbacks makes it safe to use across versions.

Applied to files:

  • elementary/monitor/dbt_project/packages.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test / test
  • GitHub Check: code-quality
🔇 Additional comments (2)
elementary/monitor/dbt_project/packages.yml (2)

4-5: Verify that the new package version provides required functionality.

The transition from a git-based dependency to a published package is operationally sound. Ensure that version 0.21.0 includes all necessary fixes and features that were previously obtained from the git-based dependency.


7-13: Update or verify commented git reference.

The commented section references a git revision (20b76374f7c1b6cc280af7652c720e6069499a19 at line 10), which differs from the revision mentioned in the AI summary (a01c958a3ee272b253d8e971e128c78a72b79239). Clarify whether:

  • The commented revision is stale/outdated and should be updated or removed, or
  • The comments reference a different branch/state that may still be relevant for future reference

Comment on lines +4 to +6
- package: elementary-data/elementary
version: 0.21.0
sha1_hash: 2b5fe24bdc902ec44d0e6f227e3441c9ffc62950
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

elementary-data/elementary dbt package releases version 0.21.0

💡 Result:

There is no v0.21.0 release. The latest releases on GitHub are:

  • dbt-data-reliability — v0.20.1 (released Oct 9, 2025). [1]
  • elementary — v0.20.0 (released Oct 9, 2025). [2]

Sources: GitHub releases pages for elementary-data/dbt-data-reliability and elementary. [1][2]


Version 0.21.0 does not exist and must be corrected.

The elementary-data/elementary package has no v0.21.0 release. The latest released version is v0.20.0 (released October 9, 2025). Update package-lock.yml to use version 0.20.0 or an earlier valid release version.

🤖 Prompt for AI Agents
In elementary/monitor/dbt_project/package-lock.yml around lines 4 to 6, the
package entry lists version 0.21.0 which does not exist; change the package
version to a valid release (e.g. 0.20.0) and update the sha1_hash accordingly
(or regenerate the package-lock.yml via the same tooling that produced it so the
checksum matches the new version).

@elazarlachkar elazarlachkar merged commit 0117979 into master Dec 7, 2025
6 checks passed
@elazarlachkar elazarlachkar deleted the core-60-oss-version-0.21.0 branch December 7, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants