-
Notifications
You must be signed in to change notification settings - Fork 204
Upgrade dbt package to 0.21.0 #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 @elazarlachkar |
WalkthroughThis PR replaces the git-based dependency on elementary-data/dbt-data-reliability with the published dbt package elementary-data/elementary version 0.21.0, updating both the package declaration and lock file accordingly. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
elementary/monitor/dbt_project/package-lock.yml(1 hunks)elementary/monitor/dbt_project/packages.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-06-19T09:03:56.968Z
Learnt from: arbiv
Repo: elementary-data/elementary PR: 1937
File: elementary/clients/dbt/databricks_patch.py:99-124
Timestamp: 2025-06-19T09:03:56.968Z
Learning: For Databricks compatibility patches in elementary, prefer simple and permissive approaches over strict version checking. The patch should apply when the target module is available, regardless of version, as the defensive programming with exception handling and fallbacks makes it safe to use across versions.
Applied to files:
elementary/monitor/dbt_project/packages.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test / test
- GitHub Check: code-quality
🔇 Additional comments (2)
elementary/monitor/dbt_project/packages.yml (2)
4-5: Verify that the new package version provides required functionality.The transition from a git-based dependency to a published package is operationally sound. Ensure that version 0.21.0 includes all necessary fixes and features that were previously obtained from the git-based dependency.
7-13: Update or verify commented git reference.The commented section references a git revision (
20b76374f7c1b6cc280af7652c720e6069499a19at line 10), which differs from the revision mentioned in the AI summary (a01c958a3ee272b253d8e971e128c78a72b79239). Clarify whether:
- The commented revision is stale/outdated and should be updated or removed, or
- The comments reference a different branch/state that may still be relevant for future reference
| - package: elementary-data/elementary | ||
| version: 0.21.0 | ||
| sha1_hash: 2b5fe24bdc902ec44d0e6f227e3441c9ffc62950 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
elementary-data/elementary dbt package releases version 0.21.0
💡 Result:
There is no v0.21.0 release. The latest releases on GitHub are:
- dbt-data-reliability — v0.20.1 (released Oct 9, 2025). [1]
- elementary — v0.20.0 (released Oct 9, 2025). [2]
Sources: GitHub releases pages for elementary-data/dbt-data-reliability and elementary. [1][2]
Version 0.21.0 does not exist and must be corrected.
The elementary-data/elementary package has no v0.21.0 release. The latest released version is v0.20.0 (released October 9, 2025). Update package-lock.yml to use version 0.20.0 or an earlier valid release version.
🤖 Prompt for AI Agents
In elementary/monitor/dbt_project/package-lock.yml around lines 4 to 6, the
package entry lists version 0.21.0 which does not exist; change the package
version to a valid release (e.g. 0.20.0) and update the sha1_hash accordingly
(or regenerate the package-lock.yml via the same tooling that produced it so the
checksum matches the new version).
null
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.