[APP-2070] UI bug fixes (#423)

* fix: button padding

* fix: notifications logic was not working properly

* update: removed unused async call

* update: moved review stars to review module

Author: nirbhayel

modules/core/module.php

@@ -61,45 +61,12 @@ public function enqueue_scripts() : void {
 		);
 	}
 
-	/**
-	 * Add review link to plugin row meta
-	 *
-	 * @param array $links
-	 * @param string $file
-	 * @return array
-	 * 
-	 */
-	public function add_plugin_row_meta( $links, $file ) {
-
-		if ( ! defined( 'EA11Y_BASE' ) || EA11Y_BASE !== $file ) {
-			return $links;
-		}
-
-		$links[] = '<a class="wp-ea11y-review" 
-						href="https://wordpress.org/support/plugin/pojo-accessibility/reviews/#new-post"
-						target="_blank" rel="noopener noreferrer" 
-						title="' . esc_attr__( 'Review our plugin', 'pojo-accessibility' ) 
-					. '">
-							<span>★</span><span>★</span><span>★</span><span>★</span><span>★</span>
-					</a>';
-
-		echo '<style>
-				.wp-ea11y-review{ display: inline-flex;flex-direction: row-reverse;} 
-				.wp-ea11y-review span{ color:#888}
-				.wp-ea11y-review span:hover{color:#ffa400}
-				.wp-ea11y-review span:hover~span{color:#ffa400}
-			</style>';
-
-		return $links;
-	}
-
 	/**
 	 * Module constructor.
 	 */
 	public function __construct() {
 		$this->register_components();
 		add_action( 'admin_enqueue_scripts', [ $this, 'enqueue_scripts' ] );
 		add_filter( 'plugin_action_links', [ $this, 'add_plugin_links' ], 10, 2 );
-		add_filter( 'plugin_row_meta', array( $this, 'add_plugin_row_meta' ), 10, 2 );
 	}
 }

modules/reviews/assets/src/components/dismiss-button.js

@@ -35,7 +35,6 @@ const DismissButton = ({ variant = 'icon' }) => {
 				flexDirection="row"
 				gap={1}
 				p={currentPage === 'feedback' ? 2 : 0}
-				pt={currentPage === 'feedback' ? 0 : 2}
 				width="100%"
 				justifyContent="end"
 			>

modules/reviews/assets/src/hooks/use-settings.js

@@ -87,15 +87,15 @@ const SettingsProvider = ({ children }) => {
 				});
 			}
 
-			if (!response?.success && parseInt(rating) < 4) {
+			if (!response?.success && parseInt(ratingToSubmit) < 4) {
 				/**
 				 * Show success message if the feedback was already submitted.
 				 */
-				await successNotification(
+				successNotification(
 					__('Feedback already submitted', 'pojo-accessibility'),
 				);
-			} else if (response?.success && parseInt(rating) < 4) {
-				await successNotification(
+			} else if (response?.success && parseInt(ratingToSubmit) < 4) {
+				successNotification(
 					__('Thank you for your feedback!', 'pojo-accessibility'),
 				);
 			}
@@ -139,26 +139,4 @@ const SettingsProvider = ({ children }) => {
 	);
 };
 
-export const useNotifications = () => {
-	const { setNotificationMessage, setNotificationType, setShowNotification } =
-		useContext(SettingsContext);
-
-	const error = (message) => {
-		setNotificationMessage(message);
-		setNotificationType('error');
-		setShowNotification(true);
-	};
-
-	const success = (message) => {
-		setNotificationMessage(message);
-		setNotificationType('success');
-		setShowNotification(true);
-	};
-
-	return {
-		success,
-		error,
-	};
-};
-
 export default SettingsProvider;

modules/reviews/module.php

@@ -208,10 +208,43 @@ public function maybe_show_review_popup() {
 		return false;
 	}
 
+	/**
+	 * Add review link to plugin row meta
+	 *
+	 * @param array $links
+	 * @param string $file
+	 * @return array
+	 * 
+	 */
+	public function add_plugin_row_meta( $links, $file ) {
+
+		if ( ! defined( 'EA11Y_BASE' ) || EA11Y_BASE !== $file ) {
+			return $links;
+		}
+
+		$links[] = '<a class="wp-ea11y-review" 
+						href="https://wordpress.org/support/plugin/pojo-accessibility/reviews/#new-post"
+						target="_blank" rel="noopener noreferrer" 
+						title="' . esc_attr__( 'Review our plugin', 'pojo-accessibility' ) 
+					. '">
+							<span>★</span><span>★</span><span>★</span><span>★</span><span>★</span>
+					</a>';
+
+		echo '<style>
+				.wp-ea11y-review{ display: inline-flex;flex-direction: row-reverse;} 
+				.wp-ea11y-review span{ color:#888}
+				.wp-ea11y-review span:hover{color:#ffa400}
+				.wp-ea11y-review span:hover~span{color:#ffa400}
+			</style>';
+
+		return $links;
+	}
+
 	public function __construct() {
 		add_action( 'admin_enqueue_scripts', [ $this, 'enqueue_scripts' ] );
 		add_action( 'admin_init', [ $this, 'register_base_data' ] );
 		add_action( 'rest_api_init', [ $this, 'register_settings' ] );
+		add_filter( 'plugin_row_meta', array( $this, 'add_plugin_row_meta' ), 10, 2 );
 
 		$this->register_routes();
 	}