Skip to content

Comment placement on GitHub is sometimes wrong #32

@scastlara

Description

@scastlara

Describe the bug
Sometimes, the comment on GitHub are not well placed. We used to have that problem before, but in that case it was due to the AI not selecting the correct lines. Now it seems different to me.

To Reproduce
No reproducer, but I have an example:

Image

#30 (comment)

Expected behavior
The comment should be placed correctly.

Additional context

We need to check:

  • Is the relative line number correctly calculated?
  • Is the git diff correctly passed to the AI?
  • Given the relative number there, are we really using the GitHub API correctly?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions