fix: show only date in GL report header

Author: scastlara

internal/publish/to_gitlab.go

@@ -16,6 +16,9 @@ import (
 // which is how we want to display it in the
 var severityScoreOrder = getSeverityScoreOrder(scanner.SeverityScoreThresholds)
 
+// now is a function that returns the current time
+var now = time.Now
+
 // PublishAsGitlabIssues creates or updates GitLab Issue reports for the given reports
 // It will add the Issue URL to the Report if it was created or updated successfully
 func PublishAsGitlabIssues(reports []scanner.Report, s gitlab.IService) {
@@ -133,12 +136,12 @@ func markdownBoolean(b bool) string {
 
 // getVulnReportHeader returns the header for the vulnerability report
 func getVulnReportHeader() string {
-	currentTime := time.Now().Local()
+	currentTime := now().Local()
 
 	return fmt.Sprintf(`
 ℹ️ This issue lists all the vulnerabilities found in the project by [Sheriff](https://gitlab.com/namespace/sheriff) on %s.
 
 Please review the vulnerabilities and take the necessary actions to fix or acknowledge them, see the [sheriff documentation](https://security-scanner-c26e93.gitlab.io/user-guide/) for more information.`,
-		currentTime.Format("2006-01-02 15:04:05"),
+		currentTime.Format("2006-01-02"),
 	)
 }

internal/publish/to_gitlab_test.go

@@ -3,6 +3,7 @@ package publish
 import (
 	"sheriff/internal/scanner"
 	"testing"
+	"time"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
@@ -184,6 +185,23 @@ func TestPublishAsGitlabIssues(t *testing.T) {
 
 }
 
+func TestGitlabIssueReportHeader(t *testing.T) {
+	origNow := now
+	now = func() time.Time {
+		return time.Date(2021, 1, 1, 0, 0, 0, 0, time.UTC)
+	}
+	defer func() {
+		now = origNow
+	}()
+
+	got := getVulnReportHeader()
+
+	want := `ℹ️ This issue lists all the vulnerabilities found in the project by [Sheriff](https://gitlab.com/namespace/sheriff) on 2021-01-01.`
+
+	assert.Contains(t, got, want)
+
+}
+
 type mockGitlabService struct {
 	mock.Mock
 }