Merge pull request #50 from sacha-c/fix-report-max-severity

fix: summary report severity count

Author: sacha-c

internal/publish/to_issue.go

@@ -67,7 +67,9 @@ func severityBiggerThan(a string, b string) bool {
 func groupVulnReportsByMaxSeverityKind(reports []scanner.Report) map[scanner.SeverityScoreKind][]scanner.Report {
 	vulnerableReports := pie.Filter(reports, func(r scanner.Report) bool { return r.IsVulnerable })
 	groupedVulnerabilities := pie.GroupBy(vulnerableReports, func(r scanner.Report) scanner.SeverityScoreKind {
-		maxSeverity := pie.SortUsing(r.Vulnerabilities, func(a, b scanner.Vulnerability) bool { return a.Severity > b.Severity })[0]
+		maxSeverity := pie.SortUsing(r.Vulnerabilities, func(a, b scanner.Vulnerability) bool {
+			return scanner.SeverityScoreThresholds[a.SeverityScoreKind] > scanner.SeverityScoreThresholds[b.SeverityScoreKind]
+		})[0]
 
 		return maxSeverity.SeverityScoreKind
 	})

internal/publish/to_slack.go

@@ -20,10 +20,10 @@ import (
 func PublishAsGeneralSlackMessage(channelNames []string, reports []scanner.Report, paths []string, s slack.IService) error {
 	var wg sync.WaitGroup
 	errChan := make(chan error, len(channelNames))
-	vulnerableReportsBySeverityKind := groupVulnReportsByMaxSeverityKind(reports)
+	vulnerableReportsByMaxSeverityKind := groupVulnReportsByMaxSeverityKind(reports)
 
-	summary := formatSummary(vulnerableReportsBySeverityKind, len(reports), paths)
-	threadMsgs := formatReportMessage(vulnerableReportsBySeverityKind)
+	summary := formatSummary(vulnerableReportsByMaxSeverityKind, len(reports), paths)
+	threadMsgs := formatReportMessage(vulnerableReportsByMaxSeverityKind)
 	for _, slackChannel := range channelNames {
 		log.Info().Str("slackChannel", slackChannel).Msg("Posting report to slack channel")
 		wg.Add(1)