Skip to content

Commit 85b7fe8

Browse files
scastlarascastlara
committed
feat: support issues on GitHub
1 parent 0daac41 commit 85b7fe8

File tree

3 files changed

+237
-48
lines changed

3 files changed

+237
-48
lines changed

‎internal/repository/github/github.go‎

Lines changed: 97 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import (
1414
"github.com/elliotchance/pie/v2"
1515
"github.com/google/go-github/v68/github"
1616
"github.com/rs/zerolog/log"
17+
"golang.org/x/oauth2"
1718
"golang.org/x/sync/errgroup"
1819
)
1920

@@ -25,7 +26,11 @@ type githubService struct {
2526

2627
// newGithubRepo creates a new GitHub repository service
2728
func New(token string) githubService {
28-
client := github.NewClient(nil)
29+
ts := oauth2.StaticTokenSource(
30+
&oauth2.Token{AccessToken: token},
31+
)
32+
tc := oauth2.NewClient(context.Background(), ts)
33+
client := github.NewClient(tc)
2934
httpClient := &http.Client{
3035
Timeout: 30 * time.Second,
3136
}
@@ -70,12 +75,101 @@ func (s githubService) GetProjectList(paths []string) (projects []repository.Pro
7075

7176
// CloseVulnerabilityIssue closes the vulnerability issue for the given project
7277
func (s githubService) CloseVulnerabilityIssue(project repository.Project) (err error) {
73-
return errors.New("CloseVulnerabilityIssue not yet implemented") // TODO #9 Add github support
78+
issue, err := s.getVulnerabilityIssue(project.GroupOrOwner, project.Name)
79+
if err != nil {
80+
return fmt.Errorf("failed to fetch current list of issues: %w", err)
81+
}
82+
if issue == nil {
83+
log.Info().Str("project", project.Path).Msg("No issue to close, nothing to do")
84+
return nil
85+
}
86+
if issue.GetState() == "closed" {
87+
log.Info().Str("project", project.Path).Msg("Issue already closed")
88+
return nil
89+
}
90+
state := "closed"
91+
_, _, err = s.client.UpdateIssue(project.GroupOrOwner, project.GroupOrOwner, issue.GetNumber(), &github.IssueRequest{
92+
State: &state,
93+
})
94+
if err != nil {
95+
return fmt.Errorf("failed to update issue: %w", err)
96+
}
97+
log.Info().Str("project", project.Path).Msg("Issue closed")
98+
return nil
7499
}
75100

76101
// OpenVulnerabilityIssue opens or updates the vulnerability issue for the given project
77102
func (s githubService) OpenVulnerabilityIssue(project repository.Project, report string) (issue *repository.Issue, err error) {
78-
return nil, errors.New("OpenVulnerabilityIssue not yet implemented") // TODO #9 Add github support
103+
vulnTitle := repository.VulnerabilityIssueTitle
104+
ghIssue, err := s.getVulnerabilityIssue(project.GroupOrOwner, project.Name)
105+
if err != nil {
106+
return nil, fmt.Errorf("[%v] Failed to fetch current list of issues: %w", project.Path, err)
107+
}
108+
if ghIssue == nil {
109+
log.Info().Str("project", project.Path).Msg("Creating new issue")
110+
newIssue := &github.IssueRequest{
111+
Title: &vulnTitle,
112+
Body: &report,
113+
}
114+
created, _, err := s.client.CreateIssue(project.GroupOrOwner, project.Name, newIssue)
115+
if err != nil {
116+
return nil, fmt.Errorf("[%v] failed to create new issue: %w", project.Path, err)
117+
}
118+
return mapGithubIssuePtr(created), nil
119+
}
120+
log.Info().Str("project", project.Path).Int("issue", ghIssue.GetNumber()).Msg("Updating existing issue")
121+
state := "open"
122+
updatedIssue := &github.IssueRequest{
123+
Body: &report,
124+
State: &state,
125+
}
126+
edited, _, err := s.client.UpdateIssue(project.GroupOrOwner, project.Name, ghIssue.GetNumber(), updatedIssue)
127+
if err != nil {
128+
return nil, fmt.Errorf("[%v] Failed to update issue: %w", project.Path, err)
129+
}
130+
if edited.GetState() != "open" {
131+
return nil, errors.New("failed to reopen issue")
132+
}
133+
return mapGithubIssuePtr(edited), nil
134+
}
135+
136+
// getVulnerabilityIssue returns the vulnerability issue for the given repo (by title)
137+
func (s githubService) getVulnerabilityIssue(owner, repo string) (*github.Issue, error) {
138+
opts := &github.IssueListByRepoOptions{
139+
State: "all",
140+
ListOptions: github.ListOptions{PerPage: 100},
141+
}
142+
vulnTitle := repository.VulnerabilityIssueTitle
143+
for {
144+
issues, resp, err := s.client.ListRepositoryIssues(owner, repo, opts)
145+
if err != nil {
146+
return nil, err
147+
}
148+
for _, issue := range issues {
149+
if issue != nil && issue.GetTitle() == vulnTitle {
150+
return issue, nil
151+
}
152+
}
153+
if resp.NextPage == 0 {
154+
break
155+
}
156+
opts.Page = resp.NextPage
157+
}
158+
return nil, nil
159+
}
160+
func mapGithubIssue(i github.Issue) repository.Issue {
161+
return repository.Issue{
162+
Title: i.GetTitle(),
163+
WebURL: i.GetHTMLURL(),
164+
}
165+
}
166+
167+
func mapGithubIssuePtr(i *github.Issue) *repository.Issue {
168+
if i == nil {
169+
return nil
170+
}
171+
issue := mapGithubIssue(*i)
172+
return &issue
79173
}
80174

81175
func (s githubService) Download(project repository.Project, dir string) (err error) {

‎internal/repository/github/github_client.go‎

Lines changed: 35 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,37 +4,67 @@ package github
44
import (
55
"context"
66
"net/url"
7+
"time"
78

89
"github.com/google/go-github/v68/github"
910
)
1011

12+
const defaultTimeout = 30 * time.Second
13+
1114
// This client is a thin wrapper around the go-github library. It provides an interface to the GitHub client
1215
// The main purpose of this client is to provide an interface to the GitHub client which can be mocked in tests.
1316
// As such this MUST be as thin as possible and MUST not contain any business logic, since it is not testable.
14-
1517
type iGithubClient interface {
1618
GetRepository(owner string, repo string) (*github.Repository, *github.Response, error)
1719
GetOrganizationRepositories(org string, opts *github.RepositoryListByOrgOptions) ([]*github.Repository, *github.Response, error)
1820
GetUserRepositories(user string, opts *github.RepositoryListByUserOptions) ([]*github.Repository, *github.Response, error)
1921
GetArchiveLink(owner string, repo string, archiveFormat github.ArchiveFormat, opts *github.RepositoryContentGetOptions) (*url.URL, *github.Response, error)
22+
ListRepositoryIssues(owner string, repo string, opts *github.IssueListByRepoOptions) ([]*github.Issue, *github.Response, error)
23+
CreateIssue(owner string, repo string, issue *github.IssueRequest) (*github.Issue, *github.Response, error)
24+
UpdateIssue(owner string, repo string, number int, issue *github.IssueRequest) (*github.Issue, *github.Response, error)
2025
}
2126

2227
type githubClient struct {
2328
client *github.Client
2429
}
2530

31+
func (c *githubClient) ListRepositoryIssues(owner, repo string, opts *github.IssueListByRepoOptions) ([]*github.Issue, *github.Response, error) {
32+
ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
33+
defer cancel()
34+
return c.client.Issues.ListByRepo(ctx, owner, repo, opts)
35+
}
36+
37+
func (c *githubClient) CreateIssue(owner, repo string, issue *github.IssueRequest) (*github.Issue, *github.Response, error) {
38+
ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
39+
defer cancel()
40+
return c.client.Issues.Create(ctx, owner, repo, issue)
41+
}
42+
43+
func (c *githubClient) UpdateIssue(owner, repo string, number int, issue *github.IssueRequest) (*github.Issue, *github.Response, error) {
44+
ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
45+
defer cancel()
46+
return c.client.Issues.Edit(ctx, owner, repo, number, issue)
47+
}
2648
func (c *githubClient) GetRepository(owner string, repo string) (*github.Repository, *github.Response, error) {
27-
return c.client.Repositories.Get(context.Background(), owner, repo)
49+
ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
50+
defer cancel()
51+
return c.client.Repositories.Get(ctx, owner, repo)
2852
}
2953

3054
func (c *githubClient) GetOrganizationRepositories(org string, opts *github.RepositoryListByOrgOptions) ([]*github.Repository, *github.Response, error) {
31-
return c.client.Repositories.ListByOrg(context.Background(), org, opts)
55+
ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
56+
defer cancel()
57+
return c.client.Repositories.ListByOrg(ctx, org, opts)
3258
}
3359

3460
func (c *githubClient) GetUserRepositories(user string, opts *github.RepositoryListByUserOptions) ([]*github.Repository, *github.Response, error) {
35-
return c.client.Repositories.ListByUser(context.Background(), user, opts)
61+
ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
62+
defer cancel()
63+
return c.client.Repositories.ListByUser(ctx, user, opts)
3664
}
3765

3866
func (c *githubClient) GetArchiveLink(owner string, repo string, archiveFormat github.ArchiveFormat, opts *github.RepositoryContentGetOptions) (*url.URL, *github.Response, error) {
39-
return c.client.Repositories.GetArchiveLink(context.Background(), owner, repo, archiveFormat, opts, 3)
67+
ctx, cancel := context.WithTimeout(context.Background(), defaultTimeout)
68+
defer cancel()
69+
return c.client.Repositories.GetArchiveLink(ctx, owner, repo, archiveFormat, opts, 3)
4070
}

‎internal/repository/github/github_test.go‎

Lines changed: 105 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -109,46 +109,6 @@ func TestGetProjectListWithNextPage(t *testing.T) {
109109
mockService.AssertExpectations(t)
110110
}
111111

112-
type mockService struct {
113-
mock.Mock
114-
}
115-
116-
func (c *mockService) GetRepository(owner string, repo string) (*github.Repository, *github.Response, error) {
117-
args := c.Called(owner, repo)
118-
var r *github.Response
119-
if resp := args.Get(1); resp != nil {
120-
r = args.Get(1).(*github.Response)
121-
}
122-
return args.Get(0).(*github.Repository), r, args.Error(2)
123-
}
124-
125-
func (c *mockService) GetOrganizationRepositories(org string, opts *github.RepositoryListByOrgOptions) ([]*github.Repository, *github.Response, error) {
126-
args := c.Called(org, opts)
127-
var r *github.Response
128-
if resp := args.Get(1); resp != nil {
129-
r = args.Get(1).(*github.Response)
130-
}
131-
return args.Get(0).([]*github.Repository), r, args.Error(2)
132-
}
133-
134-
func (c *mockService) GetUserRepositories(user string, opts *github.RepositoryListByUserOptions) ([]*github.Repository, *github.Response, error) {
135-
args := c.Called(user, opts)
136-
var r *github.Response
137-
if resp := args.Get(1); resp != nil {
138-
r = args.Get(1).(*github.Response)
139-
}
140-
return args.Get(0).([]*github.Repository), r, args.Error(2)
141-
}
142-
143-
func (c *mockService) GetArchiveLink(owner string, repo string, archiveFormat github.ArchiveFormat, opts *github.RepositoryContentGetOptions) (*url.URL, *github.Response, error) {
144-
args := c.Called(owner, repo, archiveFormat, opts)
145-
var r *github.Response
146-
if resp := args.Get(1); resp != nil {
147-
r = args.Get(1).(*github.Response)
148-
}
149-
return args.Get(0).(*url.URL), r, args.Error(2)
150-
}
151-
152112
func TestDownload(t *testing.T) {
153113
// Create temporary directory for testing
154114
tempDir, err := os.MkdirTemp("", "sheriff-clone-test-")
@@ -211,3 +171,108 @@ func TestDownload(t *testing.T) {
211171
_, err = os.Stat(filepath.Join(tempDir, "src"))
212172
assert.NoError(t, err, "src directory should exist")
213173
}
174+
175+
func TestOpenVulnerabilityIssue(t *testing.T) {
176+
title := "666"
177+
mockClient := mockService{}
178+
mockClient.On("ListRepositoryIssues", mock.Anything, mock.Anything, mock.Anything).Return([]*github.Issue{}, &github.Response{}, nil)
179+
mockClient.On("CreateIssue", mock.Anything, mock.Anything, mock.Anything).Return(&github.Issue{Title: &title}, &github.Response{}, nil)
180+
181+
svc := githubService{client: &mockClient}
182+
183+
i, err := svc.OpenVulnerabilityIssue(repository.Project{GroupOrOwner: "group", Name: "repo"}, "report")
184+
assert.Nil(t, err)
185+
assert.NotNil(t, i)
186+
assert.Equal(t, "666", i.Title)
187+
}
188+
189+
func TestCloseVulnerabilityIssue(t *testing.T) {
190+
title := "288"
191+
mockClient := mockService{}
192+
mockClient.On("ListRepositoryIssues", mock.Anything, mock.Anything, mock.Anything).Return([]*github.Issue{{Title: &title}}, &github.Response{}, nil)
193+
194+
svc := githubService{client: &mockClient}
195+
196+
err := svc.CloseVulnerabilityIssue(repository.Project{GroupOrOwner: "group", Name: "repo"})
197+
assert.Nil(t, err)
198+
}
199+
200+
func TestCloseVulnerabilityIssueNoIssue(t *testing.T) {
201+
mockClient := mockService{}
202+
mockClient.On("ListRepositoryIssues", mock.Anything, mock.Anything, mock.Anything).Return(nil, &github.Response{}, nil)
203+
204+
svc := githubService{client: &mockClient}
205+
206+
err := svc.CloseVulnerabilityIssue(repository.Project{GroupOrOwner: "group", Name: "repo"})
207+
assert.Nil(t, err)
208+
}
209+
210+
type mockService struct {
211+
mock.Mock
212+
}
213+
214+
func (c *mockService) GetRepository(owner string, repo string) (*github.Repository, *github.Response, error) {
215+
args := c.Called(owner, repo)
216+
var r *github.Response
217+
if resp := args.Get(1); resp != nil {
218+
r = args.Get(1).(*github.Response)
219+
}
220+
return args.Get(0).(*github.Repository), r, args.Error(2)
221+
}
222+
223+
func (c *mockService) GetOrganizationRepositories(org string, opts *github.RepositoryListByOrgOptions) ([]*github.Repository, *github.Response, error) {
224+
args := c.Called(org, opts)
225+
var r *github.Response
226+
if resp := args.Get(1); resp != nil {
227+
r = args.Get(1).(*github.Response)
228+
}
229+
return args.Get(0).([]*github.Repository), r, args.Error(2)
230+
}
231+
232+
func (c *mockService) GetUserRepositories(user string, opts *github.RepositoryListByUserOptions) ([]*github.Repository, *github.Response, error) {
233+
args := c.Called(user, opts)
234+
var r *github.Response
235+
if resp := args.Get(1); resp != nil {
236+
r = args.Get(1).(*github.Response)
237+
}
238+
return args.Get(0).([]*github.Repository), r, args.Error(2)
239+
}
240+
241+
func (c *mockService) GetArchiveLink(owner string, repo string, archiveFormat github.ArchiveFormat, opts *github.RepositoryContentGetOptions) (*url.URL, *github.Response, error) {
242+
args := c.Called(owner, repo, archiveFormat, opts)
243+
var r *github.Response
244+
if resp := args.Get(1); resp != nil {
245+
r = args.Get(1).(*github.Response)
246+
}
247+
return args.Get(0).(*url.URL), r, args.Error(2)
248+
}
249+
250+
func (c *mockService) ListRepositoryIssues(owner, repo string, opts *github.IssueListByRepoOptions) ([]*github.Issue, *github.Response, error) {
251+
args := c.Called(owner, repo, opts)
252+
var r *github.Response
253+
if resp := args.Get(1); resp != nil {
254+
r = args.Get(1).(*github.Response)
255+
}
256+
if args.Get(0) == nil {
257+
return nil, r, args.Error(2)
258+
}
259+
return args.Get(0).([]*github.Issue), r, args.Error(2)
260+
}
261+
262+
func (c *mockService) CreateIssue(owner, repo string, issue *github.IssueRequest) (*github.Issue, *github.Response, error) {
263+
args := c.Called(owner, repo)
264+
var r *github.Response
265+
if resp := args.Get(1); resp != nil {
266+
r = args.Get(1).(*github.Response)
267+
}
268+
return args.Get(0).(*github.Issue), r, args.Error(2)
269+
}
270+
271+
func (c *mockService) UpdateIssue(owner string, repo string, number int, issue *github.IssueRequest) (*github.Issue, *github.Response, error) {
272+
args := c.Called(owner, repo)
273+
var r *github.Response
274+
if resp := args.Get(1); resp != nil {
275+
r = args.Get(1).(*github.Response)
276+
}
277+
return args.Get(0).(*github.Issue), r, args.Error(2)
278+
}

0 commit comments

Comments
 (0)