refactor(#52): download gh repo instead of using git clone #62
Conversation
|
/lgtm review |
scastlara
force-pushed
the
archive-gh
branch
from
bb07a93 to
8b0416d
Compare
scastlara
force-pushed
the
archive-gh
branch
from
23fd17e to
d488de3
Compare
|
/lgtm review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🦉 lgtm Review
Score: LGTM 👍
🔍 Summary
The PR is a well-executed refactor that successfully replaces the go-git dependency with a direct download and extraction mechanism. The extraction logic has been correctly moved to a new compress package, promoting code reuse and maintainability. The new Download functionality in both GitHub and GitLab services is properly implemented, including error handling, context with timeouts for HTTP requests, and robust path traversal prevention in the extractor. Comprehensive tests have been added for the GitHub download feature, ensuring its correctness.
Overall, the changes improve the project's dependency footprint, code organization, and maintainability. No major issues were found.
More information
- Id:
6976451242324e6f93090ba757525b37 - Model:
gemini-2.5-flash-preview-05-20 - Created at:
2025-09-18T10:30:40.400968+00:00
Usage summary
- Request count:
2 - Request tokens:
80,108 - Response tokens:
3,407 - Total tokens:
83,515
See the 📚 lgtm-ai repository for more information about lgtm.
scastlara
force-pushed
the
archive-gh
branch
from
d488de3 to
45a985b
Compare
scastlara
force-pushed
the
archive-gh
branch
from
ffcdd54 to
0daac41
Compare
Tested:
We got rid of one dependency (go-git), yay!
As we agreed, I moved the uncompressing thing to its own package.
closes #52